tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
Archived
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

fix: groupId -> forGroup

Browse source
This commit is contained in:
Tibo De Peuter 2025-05-20 13:13:23 +02:00
parent c04b13c555
commit dea9930705
Signed by: tdpeuter
GPG key ID: 38297DE43F75FFE2
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
backend/src/middleware/auth/checks/submission-checks.ts
View file

@ -34,15 +34,15 @@ export const onlyAllowIfHasAccessToSubmission = authorize(async (auth: Authentic
});
export const onlyAllowIfHasAccessToSubmissionFromParams = authorize(async (auth: AuthenticationInfo, req: AuthenticatedRequest) => {
const { classId, assignmentId, groupId } = req.query;
const { classId, assignmentId, forGroup } = req.query;
requireFields({ classId, assignmentId, groupId });
requireFields({ classId, assignmentId, forGroup });
if (auth.accountType === AccountType.Teacher) {
const cls = await fetchClass(classId as string);
return cls.teachers.map(mapToUsername).includes(auth.username);
}
const group = await fetchGroup(classId as string, Number(assignmentId as string), Number(groupId as string));
const group = await fetchGroup(classId as string, Number(assignmentId as string), Number(forGroup as string));
return group.members.map(mapToUsername).includes(auth.username);
});

4
frontend/src/controllers/submissions.ts
View file

@ -23,7 +23,7 @@ export class SubmissionController extends BaseController {
groupId?: number,
full = true,
): Promise<SubmissionsResponse> {
return this.get<SubmissionsResponse>(`/`, { language, version, classId, assignmentId, groupId, full });
return this.get<SubmissionsResponse>(`/`, { language, version, classId, assignmentId, forGroup: groupId, full });
}
async getByNumber(
@ -39,7 +39,7 @@ export class SubmissionController extends BaseController {
version,
classId,
assignmentId,
groupId,
forGroup: groupId,
});
}