From dea99307053d236fa6608ae8c1bf1b03adc5d422 Mon Sep 17 00:00:00 2001 From: Tibo De Peuter Date: Tue, 20 May 2025 13:13:23 +0200 Subject: [PATCH] fix: groupId -> forGroup --- backend/src/middleware/auth/checks/submission-checks.ts | 6 +++--- frontend/src/controllers/submissions.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/backend/src/middleware/auth/checks/submission-checks.ts b/backend/src/middleware/auth/checks/submission-checks.ts index 9caae176..1b781773 100644 --- a/backend/src/middleware/auth/checks/submission-checks.ts +++ b/backend/src/middleware/auth/checks/submission-checks.ts @@ -34,15 +34,15 @@ export const onlyAllowIfHasAccessToSubmission = authorize(async (auth: Authentic }); export const onlyAllowIfHasAccessToSubmissionFromParams = authorize(async (auth: AuthenticationInfo, req: AuthenticatedRequest) => { - const { classId, assignmentId, groupId } = req.query; + const { classId, assignmentId, forGroup } = req.query; - requireFields({ classId, assignmentId, groupId }); + requireFields({ classId, assignmentId, forGroup }); if (auth.accountType === AccountType.Teacher) { const cls = await fetchClass(classId as string); return cls.teachers.map(mapToUsername).includes(auth.username); } - const group = await fetchGroup(classId as string, Number(assignmentId as string), Number(groupId as string)); + const group = await fetchGroup(classId as string, Number(assignmentId as string), Number(forGroup as string)); return group.members.map(mapToUsername).includes(auth.username); }); diff --git a/frontend/src/controllers/submissions.ts b/frontend/src/controllers/submissions.ts index 0be1c122..69204633 100644 --- a/frontend/src/controllers/submissions.ts +++ b/frontend/src/controllers/submissions.ts @@ -23,7 +23,7 @@ export class SubmissionController extends BaseController { groupId?: number, full = true, ): Promise { - return this.get(`/`, { language, version, classId, assignmentId, groupId, full }); + return this.get(`/`, { language, version, classId, assignmentId, forGroup: groupId, full }); } async getByNumber( @@ -39,7 +39,7 @@ export class SubmissionController extends BaseController { version, classId, assignmentId, - groupId, + forGroup: groupId, }); }