tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
Archived
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

feat(frontend): overbodig imports wegdoen

Browse source
This commit is contained in:
Joyelle Ndagijimana 2025-04-13 16:33:05 +02:00
parent d6009ff878
commit 0486cfec84
2 changed files with 8 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

10
frontend/src/views/assignments/StudentAssignment.vue
View file

@ -8,6 +8,8 @@ import type {AssignmentResponse} from "@/controllers/assignments.ts";
import type {GroupDTO} from "@dwengo-1/common/interfaces/group"; import type {GroupDTO} from "@dwengo-1/common/interfaces/group";
import {asyncComputed} from "@vueuse/core"; import {asyncComputed} from "@vueuse/core";
import {useStudentsByUsernamesQuery} from "@/queries/students.ts"; import {useStudentsByUsernamesQuery} from "@/queries/students.ts";
import {AssignmentDTO} from "@dwengo-1/common/dist/interfaces/assignment.ts";
import {StudentDTO} from "@dwengo-1/common/dist/interfaces/student.ts";
const props = defineProps<{ const props = defineProps<{
classId: string classId: string
@ -35,9 +37,14 @@ const group = computed(() => {
return props?.groups?.find(group => return props?.groups?.find(group =>
group.members.some(m => m.username === username.value) group.members.some(m => m.username === username.value)
); );
/** For testing
return {assignment: 1,
groupNumber: 1,
members: ["testleerling1"]}
*/
}); });
// Assuming group.value.members is a list of usernames // Assuming group.value.members is a list of usernames TODO: case when it's StudentDTO's
const studentQueries = useStudentsByUsernamesQuery(() => group.value?.members as string[]); const studentQueries = useStudentsByUsernamesQuery(() => group.value?.members as string[]);
</script> </script>
@ -85,7 +92,6 @@ const studentQueries = useStudentsByUsernamesQuery(() => group.value?.members as
<v-card-text class="group-section"> <v-card-text class="group-section">
<h3>{{ t("group") }}</h3> <h3>{{ t("group") }}</h3>
<pre>{{ props.groups }}</pre>
<div v-if="studentQueries"> <div v-if="studentQueries">
<ul> <ul>
<li v-for="student in studentQueries" :key="student.data?.student.id"> <li v-for="student in studentQueries" :key="student.data?.student.id">

11
frontend/src/views/assignments/TeacherAssignment.vue
View file

@ -18,17 +18,6 @@ const controller = new AssignmentController(props.classId);
const assignmentQueryResult = useAssignmentQuery(() => props.classId, props.assignmentId); const assignmentQueryResult = useAssignmentQuery(() => props.classId, props.assignmentId);
/***
// Display group members
const myGroup = computed(() => {
if (!assignment.value || !assignment.value.groups) return null;
console.log(assignment.value.groups)
return assignment.value.groups.find(group =>
group.members.some(m => m.username === myUsername)
);
});
*/
const deleteAssignment = async () => { const deleteAssignment = async () => {
await controller.deleteAssignment(props.assignmentId.value); await controller.deleteAssignment(props.assignmentId.value);
}; };