From 0486cfec84a77ec1497ab348a917d1e2ac4fb665 Mon Sep 17 00:00:00 2001 From: Joyelle Ndagijimana Date: Sun, 13 Apr 2025 16:33:05 +0200 Subject: [PATCH] feat(frontend): overbodig imports wegdoen --- frontend/src/views/assignments/StudentAssignment.vue | 10 ++++++++-- frontend/src/views/assignments/TeacherAssignment.vue | 11 ----------- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/frontend/src/views/assignments/StudentAssignment.vue b/frontend/src/views/assignments/StudentAssignment.vue index ca5b8a4e..88a58d0f 100644 --- a/frontend/src/views/assignments/StudentAssignment.vue +++ b/frontend/src/views/assignments/StudentAssignment.vue @@ -8,6 +8,8 @@ import type {AssignmentResponse} from "@/controllers/assignments.ts"; import type {GroupDTO} from "@dwengo-1/common/interfaces/group"; import {asyncComputed} from "@vueuse/core"; import {useStudentsByUsernamesQuery} from "@/queries/students.ts"; +import {AssignmentDTO} from "@dwengo-1/common/dist/interfaces/assignment.ts"; +import {StudentDTO} from "@dwengo-1/common/dist/interfaces/student.ts"; const props = defineProps<{ classId: string @@ -35,9 +37,14 @@ const group = computed(() => { return props?.groups?.find(group => group.members.some(m => m.username === username.value) ); + /** For testing + return {assignment: 1, + groupNumber: 1, + members: ["testleerling1"]} + */ }); -// Assuming group.value.members is a list of usernames +// Assuming group.value.members is a list of usernames TODO: case when it's StudentDTO's const studentQueries = useStudentsByUsernamesQuery(() => group.value?.members as string[]); @@ -85,7 +92,6 @@ const studentQueries = useStudentsByUsernamesQuery(() => group.value?.members as

{{ t("group") }}

-
{{ props.groups }}
  • diff --git a/frontend/src/views/assignments/TeacherAssignment.vue b/frontend/src/views/assignments/TeacherAssignment.vue index f6545c90..5fb28e57 100644 --- a/frontend/src/views/assignments/TeacherAssignment.vue +++ b/frontend/src/views/assignments/TeacherAssignment.vue @@ -18,17 +18,6 @@ const controller = new AssignmentController(props.classId); const assignmentQueryResult = useAssignmentQuery(() => props.classId, props.assignmentId); -/*** - // Display group members - const myGroup = computed(() => { - if (!assignment.value || !assignment.value.groups) return null; - console.log(assignment.value.groups) - return assignment.value.groups.find(group => - group.members.some(m => m.username === myUsername) - ); - }); - */ - const deleteAssignment = async () => { await controller.deleteAssignment(props.assignmentId.value); };