chore: Move inverted logic to viewing_ray from main

This commit is contained in:
Tibo De Peuter 2024-10-11 13:30:47 +02:00
parent a133ca3274
commit a7484f1748
Signed by: tdpeuter
GPG key ID: 38297DE43F75FFE2
2 changed files with 4 additions and 4 deletions

View file

@ -87,9 +87,7 @@ int main(int argc, char * argv[])
// Compute viewing ray
Ray ray;
/* NOTE I flipped the vertical axis of the pixels, because in computer graphics we assume the bottom left pixel
* is (0,0), while traditional jpg assumes (0,0) to be the upper left pixel. */
viewing_ray(camera,height - i,j,width,height,ray);
viewing_ray(camera,i,j,width,height,ray);
// Find first visible object hit by ray and its surface normal n
double t;

View file

@ -18,5 +18,7 @@ void viewing_ray(
double v = 0 - camera.height / 2 + camera.height * (i + 0.5) / height;
ray.origin = camera.e;
ray.direction = (0 - camera.d) * camera.w + u * camera.u + v * camera.v;
/* NOTE I flipped the vertical axis of the pixels, because in computer graphics we assume the bottom left pixel
* is (0,0), while traditional jpg assumes (0,0) to be the upper left pixel. */
ray.direction = (0 - camera.d) * camera.w + u * camera.u - v * camera.v;
}