1
Fork 0

fix: typos and nonexistent calls

This commit is contained in:
Tibo De Peuter 2026-04-15 18:34:28 +02:00
parent 5a358fadde
commit e40a4b979f
Signed by: tdpeuter
SSH key fingerprint: SHA256:u/h/LVoqKF1Iz02uOyxe6hcjmoZASCGV2HM0TG9ZMoU
7 changed files with 52 additions and 50 deletions

View file

@ -1,5 +1,5 @@
from dataclasses import dataclass, field
from typing import List
from typing import List, Optional
@dataclass
@ -18,14 +18,20 @@ class ArchitectureConfig:
See docs/design/actor-critic.md for the full design rationale.
"""
# Input network: maps global observation to a hidden representation.
feature_extractor: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[64, 64], activation="tanh")
)
# Output network: maps the hidden representation to a scalar value estimate.
critic: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[], activation="tanh")
)
name: str = "base"
# Actor pipeline
sensor: Optional[LayerConfig] = None
propagator: Optional[LayerConfig] = None
motor: Optional[LayerConfig] = None
# Critic pipeline
feature_extractor: Optional[LayerConfig] = None
critic: Optional[LayerConfig] = None
# Decentralized
message_passing_steps: Optional[int] = None
topology_type: Optional[str] = None # Supported values: "ring", "fully_connected"
@dataclass
@ -39,14 +45,7 @@ class CentralizedConfig(ArchitectureConfig):
See docs/design/actor-critic.md for the full design rationale.
"""
# Input network: maps the global observation to a hidden state.
sensor: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[64, 64], activation="tanh")
)
# Output network: projects hidden state to (mean, log_std) over all joints.
motor: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[], activation="tanh")
)
name: str = "centralized"
@dataclass
@ -64,21 +63,4 @@ class DecentralizedConfig(ArchitectureConfig):
full design rationale.
"""
# Input network: local observation -> initial hidden state per node.
sensor: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[64, 64], activation="tanh")
)
# Message-passing network: aggregates neighbour messages and updates hidden state.
propagator: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[64, 64], activation="tanh")
)
# Output network: final hidden state -> joint offset for this node only.
motor: LayerConfig = field(
default_factory=lambda: LayerConfig(hidden_dims=[], activation="tanh")
)
# Number of synchronous message-passing rounds per control step.
message_passing_steps: int = 1
# Graph topology used for neighbour connections.
# Supported values: "ring", "fully_connected".
topology_type: str = "ring"
name: str = "decentralized"

View file

@ -29,8 +29,8 @@ def register_configs() -> None:
cs.store(group="ppo", name="base_ppo", node=PPOConfig)
# Architecture variants — swap via CLI: architecture=decentralized
cs.store(group="architecture", name="centralized", node=CentralizedConfig)
cs.store(group="architecture", name="decentralized", node=DecentralizedConfig)
cs.store(group="architecture", name="centralized_schema", node=CentralizedConfig)
cs.store(group="architecture", name="decentralized_schema", node=DecentralizedConfig)
# Environment configs
cs.store(group="morphology", name="base_morphology", node=MorphologyConfig)

View file

@ -527,11 +527,11 @@ class PPOTrainer:
f"ETA {eta_str}"
)
if getattr(self.config.experiment, "debug_sanity", False):
self.logger.log(
if getattr(self.cfg.experiment, "debug_sanity", False):
self.logger.info(
"\n[SANITY CHECK] Successfully completed 1 epoch of data collection and gradient updates."
)
self.logger.log("[SANITY CHECK] Gradients flowed without NaN. Exiting gracefully.")
self.logger.info("[SANITY CHECK] Gradients flowed without NaN. Exiting gracefully.")
break
if self.logging_cfg.save_model:

View file

@ -53,7 +53,7 @@ def init_logger(**kwargs) -> "UnifiedLogger":
the output directories and set up all logging backends.
"""
global _active_logger
logger = UnifiedLogger(_set_as_global=False, **kwargs)
logger = UnifiedLogger(**kwargs)
_active_logger = logger
return logger