From 27d5c5cbabda74e15988748f52850977defd86a6 Mon Sep 17 00:00:00 2001 From: Timo De Meyst Date: Tue, 18 Mar 2025 10:28:13 +0100 Subject: [PATCH 1/5] actions: workflows update workflows worden op PR uitgevoerd voor elke nodige mogelijke update van een PR --- .github/workflows/lint-action.yml | 1 + .github/workflows/testing.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/lint-action.yml b/.github/workflows/lint-action.yml index b8137275..c59191ed 100644 --- a/.github/workflows/lint-action.yml +++ b/.github/workflows/lint-action.yml @@ -11,6 +11,7 @@ on: pull_request: branches: - dev + types: ["synchronize", "ready_for_review", "opened", "reopened"] # Down scope as necessary via https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 4913f9fc..ce08509b 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -8,6 +8,7 @@ on: branches: [ "dev" ] pull_request: branches: [ "dev" ] + types: ["synchronize", "ready_for_review", "opened", "reopened"] jobs: test: From f4397255397635182ed1212fa868fd31af8a944d Mon Sep 17 00:00:00 2001 From: Lint Action Date: Tue, 18 Mar 2025 09:29:23 +0000 Subject: [PATCH 2/5] style: fix linting issues met ESLint --- frontend/vite.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts index 845e025f..2fad8e54 100644 --- a/frontend/vite.config.ts +++ b/frontend/vite.config.ts @@ -13,6 +13,6 @@ export default defineConfig({ }, }, build: { - target: 'esnext' //browsers can handle the latest ES features + target: 'esnext' //Browsers can handle the latest ES features }, }); From 641266f0fe7e893fe184f0acf05c6389c39b5c8a Mon Sep 17 00:00:00 2001 From: Lint Action Date: Tue, 18 Mar 2025 09:29:27 +0000 Subject: [PATCH 3/5] style: fix linting issues met Prettier --- frontend/vite.config.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/vite.config.ts b/frontend/vite.config.ts index 2fad8e54..8f5f992b 100644 --- a/frontend/vite.config.ts +++ b/frontend/vite.config.ts @@ -13,6 +13,6 @@ export default defineConfig({ }, }, build: { - target: 'esnext' //Browsers can handle the latest ES features - }, + target: "esnext", //Browsers can handle the latest ES features + }, }); From 08d45996640f38980179aec81c5129c65b545f47 Mon Sep 17 00:00:00 2001 From: Timo De Meyst Date: Tue, 18 Mar 2025 10:57:58 +0100 Subject: [PATCH 4/5] actions: update testing workflow npm run build is niet nodig om te testen --- .github/workflows/testing.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index ce08509b..20e7d221 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -29,5 +29,4 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'npm' - run: npm ci - - run: npm run build --if-present - run: npm run test:unit From ec8efc554ea1b9ad5f71667c83c099c6c8c8fea2 Mon Sep 17 00:00:00 2001 From: Timo De Meyst Date: Tue, 18 Mar 2025 11:02:51 +0100 Subject: [PATCH 5/5] test: test:unit script update unit tests worden enkel uitgevoerd in de back- en frontend workspaces --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index db7f5ba3..b96114ae 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "format-check": "npm run format-check --ws", "generate-docs": "python3 -m venv .venv && source .venv/bin/activate && pip install -r docs/requirements.txt && python docs/architecture/schema.py", "lint": "npm run lint --ws", - "test:unit": "npm run test:unit --ws" + "test:unit": "npm run test:unit -w backend -w frontend" }, "workspaces": [ "backend",