tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
Archived
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

fix: return types enz gefixt services/assignments.ts

Browse source
This commit is contained in:
Adriaan Jacquet 2025-04-06 18:32:54 +02:00
parent c52bcde3ae
commit e562fad385
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
backend/src/services/assignments.ts
View file

@ -44,13 +44,12 @@ export async function createAssignment(classid: string, assignmentData: Assignme
const cls = await fetchClass(classid); const cls = await fetchClass(classid);
const assignment = mapToAssignment(assignmentData, cls); const assignment = mapToAssignment(assignmentData, cls);
const assignmentRepository = getAssignmentRepository(); const assignmentRepository = getAssignmentRepository();
const newAssignment = assignmentRepository.create(assignment); const newAssignment = assignmentRepository.create(assignment);
await assignmentRepository.save(newAssignment, {preventOverwrite: true}); await assignmentRepository.save(newAssignment, {preventOverwrite: true});
return mapToAssignmentDTO(newAssignment); return mapToAssignmentDTO(newAssignment);
} }
export async function getAssignment(classid: string, id: number): Promise<AssignmentDTO> { export async function getAssignment(classid: string, id: number): Promise<AssignmentDTO> {
@ -68,12 +67,10 @@ export async function getAssignmentsSubmissions(
const groupRepository = getGroupRepository(); const groupRepository = getGroupRepository();
const groups = await groupRepository.findAllGroupsForAssignment(assignment); const groups = await groupRepository.findAllGroupsForAssignment(assignment);
if (groups.length === 0){
throw new NotFoundException('No groups for assignment found');
}
const submissionRepository = getSubmissionRepository(); const submissionRepository = getSubmissionRepository();
const submissions = (await Promise.all(groups.map(async (group) => submissionRepository.findAllSubmissionsForGroup(group)))).flat(); const submissions = (await Promise.all(
groups.map(async (group) => submissionRepository.findAllSubmissionsForGroup(group))
)).flat();
if (full) { if (full) {
return submissions.map(mapToSubmissionDTO); return submissions.map(mapToSubmissionDTO);
@ -96,5 +93,5 @@ export async function getAssignmentsQuestions(
return questions.map(mapToQuestionDTO); return questions.map(mapToQuestionDTO);
} }
return questions.map(mapToQuestionDTO); // mapToQuestionId should be updated return questions.map(mapToQuestionDTO);
} }