From db9b9ce2cd0e68f7bd0b9761ae29cce5b9b6ec23 Mon Sep 17 00:00:00 2001
From: laurejablonski <laure.jablonski@ugent.be>
Date: Sun, 27 Apr 2025 11:04:17 +0200
Subject: [PATCH] test: students data

---
 backend/tests/data/users/students.test.ts                | 9 ++++++---
 .../tests/test_assets/content/attachments.testdata.ts    | 1 +
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/backend/tests/data/users/students.test.ts b/backend/tests/data/users/students.test.ts
index 42822557..ee607f74 100644
--- a/backend/tests/data/users/students.test.ts
+++ b/backend/tests/data/users/students.test.ts
@@ -2,6 +2,8 @@ import { setupTestApp } from '../../setup-tests.js';
 import { describe, it, expect, beforeAll } from 'vitest';
 import { StudentRepository } from '../../../src/data/users/student-repository.js';
 import { getStudentRepository } from '../../../src/data/repositories.js';
+import { getNameOfJSDocTypedef } from 'typescript';
+import { getNoordkaap } from '../../test_assets/users/students.testdata.js';
 
 const username = 'teststudent';
 const firstName = 'John';
@@ -21,11 +23,12 @@ describe('StudentRepository', () => {
     });
 
     it('should return student from the datbase', async () => {
-        const student = await studentRepository.findByUsername('Noordkaap');
+        const expectation = getNoordkaap();
+        const student = await studentRepository.findByUsername(expectation.username);
 
         expect(student).toBeTruthy();
-        expect(student?.firstName).toBe('Stijn');
-        expect(student?.lastName).toBe('Meuris');
+        expect(student?.firstName).toBe(expectation.firstName);
+        expect(student?.lastName).toBe(expectation.lastName);
     });
 
     it('should return the queried student after he was added', async () => {
diff --git a/backend/tests/test_assets/content/attachments.testdata.ts b/backend/tests/test_assets/content/attachments.testdata.ts
index 6b905c0d..1f1bc042 100644
--- a/backend/tests/test_assets/content/attachments.testdata.ts
+++ b/backend/tests/test_assets/content/attachments.testdata.ts
@@ -4,6 +4,7 @@ import { testLearningObject01 } from './learning-objects.testdata';
 import { LearningObject } from '../../../src/entities/content/learning-object.entity';
 
 export function makeTestAttachments(em: EntityManager): Attachment[] {
+    // prevent duplicate insertion
     const lo = em.merge(LearningObject, testLearningObject01);
 
     attachment01 = em.create(Attachment, {