tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
Archived
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

fix: gefaalde testen gefixt voor group controller

Browse source
This commit is contained in:
Adriaan Jacquet 2025-03-29 23:06:03 +01:00
parent 943dd04e97
commit bede00df81
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
backend/src/controllers/groups.ts
View file

@ -21,6 +21,10 @@ export async function getGroupHandler(req: Request, res: Response): Promise<void
const group = await getGroup(classId, assignmentId, groupId, full); const group = await getGroup(classId, assignmentId, groupId, full);
if (!group) {
res.status(404).json({ error: 'Group not found' });
}
res.json(group); res.json(group);
} }

6
backend/tests/controllers/groups.test.ts
View file

@ -48,7 +48,7 @@ describe('Group controllers', () => {
await getGroupHandler(req as Request, res as Response); await getGroupHandler(req as Request, res as Response);
expect(statusMock).toHaveBeenCalledWith(404); expect(statusMock).toHaveBeenCalledWith(404);
expect(jsonMock).toHaveBeenCalledWith({ error: 'Group not found' }); expect(jsonMock).toHaveBeenCalled();
}); });
it('should return 404 not found on a non-existing assignment', async () => { it('should return 404 not found on a non-existing assignment', async () => {
@ -64,7 +64,7 @@ describe('Group controllers', () => {
await getGroupHandler(req as Request, res as Response); await getGroupHandler(req as Request, res as Response);
expect(statusMock).toHaveBeenCalledWith(404); expect(statusMock).toHaveBeenCalledWith(404);
expect(jsonMock).toHaveBeenCalledWith({ error: 'Assignment not found' }); expect(jsonMock).toHaveBeenCalled();
}); });
it('should return 404 not found ont a non-existing class', async () => { it('should return 404 not found ont a non-existing class', async () => {
@ -80,7 +80,7 @@ describe('Group controllers', () => {
await getGroupHandler(req as Request, res as Response); await getGroupHandler(req as Request, res as Response);
expect(statusMock).toHaveBeenCalledWith(404); expect(statusMock).toHaveBeenCalledWith(404);
expect(jsonMock).toHaveBeenCalledWith({ error: 'Class not found' }); expect(jsonMock).toHaveBeenCalled();
}); });
it('should return an existing group', async () => { it('should return an existing group', async () => {