tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

fix(backend): Verdere door de aanpassingen veroorzaakte compilatiefouten opgelost

Browse source
This commit is contained in:
Gerald Schmittinger 2025-04-07 00:44:20 +02:00
parent f9b83bc4af
commit b1df95da63
7 changed files with 46 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

15
backend/src/controllers/questions.ts
View file

@ -4,6 +4,7 @@ import { FALLBACK_LANG, FALLBACK_SEQ_NUM } from '../config.js';
import { LearningObjectIdentifier } from '../entities/content/learning-object-identifier.js';
import { QuestionDTO, QuestionId } from '@dwengo-1/common/interfaces/question';
import { Language } from '@dwengo-1/common/util/language';
import {getGroup} from "../services/groups";
function getObjectId(req: Request, res: Response): LearningObjectIdentifier | null {
const { hruid, version } = req.params;
@ -21,16 +22,18 @@ function getObjectId(req: Request, res: Response): LearningObjectIdentifier | nu
};
}
function getQuestionId(req: Request, res: Response): QuestionId | null {
const seq = req.params.seq;
async function getQuestionId(req: Request, res: Response): Promise<QuestionId | null> {
const { seq, classId, assignmentId, groupId } = req.params
const learningObjectIdentifier = getObjectId(req, res);
const groupIdentifier = await getGroup(classId, parseInt(assignmentId), parseInt(groupId), false);
if (!learningObjectIdentifier) {
if (!learningObjectIdentifier || !groupIdentifier) {
return null;
}
return {
learningObjectIdentifier,
inGroup: groupIdentifier,
sequenceNumber: seq ? Number(seq) : FALLBACK_SEQ_NUM,
};
}
@ -53,7 +56,7 @@ export async function getAllQuestionsHandler(req: Request, res: Response): Promi
}
export async function getQuestionHandler(req: Request, res: Response): Promise<void> {
const questionId = getQuestionId(req, res);
const questionId = await getQuestionId(req, res);
if (!questionId) {
return;
@ -69,7 +72,7 @@ export async function getQuestionHandler(req: Request, res: Response): Promise<v
}
export async function getQuestionAnswersHandler(req: Request, res: Response): Promise<void> {
const questionId = getQuestionId(req, res);
const questionId = await getQuestionId(req, res);
const full = req.query.full === 'true';
if (!questionId) {
@ -103,7 +106,7 @@ export async function createQuestionHandler(req: Request, res: Response): Promis
}
export async function deleteQuestionHandler(req: Request, res: Response): Promise<void> {
const questionId = getQuestionId(req, res);
const questionId = await getQuestionId(req, res);
if (!questionId) {
return;