tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

style: fix linting issues met ESLint

Browse source
This commit is contained in:
Lint Action 2025-04-18 23:36:16 +00:00
parent 51a9b58a20
commit af8c783a26
4 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
backend/tests/services/learning-objects/database-learning-object-provider.test.ts
View file

@ -38,7 +38,7 @@ describe('DatabaseLearningObjectProvider', () => {
it('should return the learning object when it is queried by its id', async () => { it('should return the learning object when it is queried by its id', async () => {
const result: FilteredLearningObject | null = await databaseLearningObjectProvider.getLearningObjectById(exampleLearningObject); const result: FilteredLearningObject | null = await databaseLearningObjectProvider.getLearningObjectById(exampleLearningObject);
expect(result).toBeTruthy(); expect(result).toBeTruthy();
expectToBeCorrectFilteredLearningObject(result!, exampleLearningObject); expectToBeCorrectFilteredLearningObject(result, exampleLearningObject);
}); });
it('should return the learning object when it is queried by only hruid and language (but not version)', async () => { it('should return the learning object when it is queried by only hruid and language (but not version)', async () => {
@ -47,7 +47,7 @@ describe('DatabaseLearningObjectProvider', () => {
language: exampleLearningObject.language, language: exampleLearningObject.language,
}); });
expect(result).toBeTruthy(); expect(result).toBeTruthy();
expectToBeCorrectFilteredLearningObject(result!, exampleLearningObject); expectToBeCorrectFilteredLearningObject(result, exampleLearningObject);
}); });
it('should return null when queried with an id that does not exist', async () => { it('should return null when queried with an id that does not exist', async () => {

10
frontend/src/queries/submissions.ts
View file

@ -63,7 +63,7 @@ export async function invalidateAllSubmissionKeys(
} }
function checkEnabled(properties: MaybeRefOrGetter<unknown>[]): boolean { function checkEnabled(properties: MaybeRefOrGetter<unknown>[]): boolean {
return properties.every(prop => !!toValue(prop)); return properties.every(prop => Boolean(toValue(prop)));
} }
export function useSubmissionsQuery( export function useSubmissionsQuery(
@ -87,7 +87,7 @@ export function useSubmissionsQuery(
const fullVal = toValue(full); const fullVal = toValue(full);
const response = await new SubmissionController(hruidVal!).getAll( const response = await new SubmissionController(hruidVal!).getAll(
languageVal!, versionVal!, classIdVal!, assignmentNumberVal!, groupNumberVal, fullVal languageVal, versionVal!, classIdVal!, assignmentNumberVal!, groupNumberVal, fullVal
); );
return response ? response.submissions as SubmissionDTO[] : undefined; return response ? response.submissions as SubmissionDTO[] : undefined;
}, },
@ -114,12 +114,12 @@ export function useSubmissionQuery(
return useQuery({ return useQuery({
queryKey: computed(() => submissionQueryKey( queryKey: computed(() => submissionQueryKey(
hruidVal!, languageVal!, versionVal!, classIdVal!, assignmentNumberVal!, groupNumberVal!, submissionNumberVal! hruidVal!, languageVal, versionVal!, classIdVal!, assignmentNumberVal!, groupNumberVal!, submissionNumberVal!
)), )),
queryFn: async () => new SubmissionController(hruidVal!).getByNumber( queryFn: async () => new SubmissionController(hruidVal!).getByNumber(
languageVal!, versionVal!, classIdVal!, assignmentNumberVal!, groupNumberVal!, submissionNumberVal! languageVal, versionVal!, classIdVal!, assignmentNumberVal!, groupNumberVal!, submissionNumberVal!
), ),
enabled: () => !!hruidVal && !!languageVal && !!versionVal && !!classIdVal && !!assignmentNumberVal && !!submissionNumber, enabled: () => Boolean(hruidVal) && Boolean(languageVal) && Boolean(versionVal) && Boolean(classIdVal) && Boolean(assignmentNumberVal) && Boolean(submissionNumber),
}); });
} }

10
frontend/src/utils/deep-equals.ts
View file

@ -1,20 +1,20 @@
export function deepEquals<T>(a: T, b: T): boolean { export function deepEquals<T>(a: T, b: T): boolean {
if (a === b) return true; if (a === b) {return true;}
if (typeof a !== 'object' || typeof b !== 'object' || a == null || b == null) if (typeof a !== 'object' || typeof b !== 'object' || a == null || b == null)
return false; {return false;}
if (Array.isArray(a) !== Array.isArray(b)) return false; if (Array.isArray(a) !== Array.isArray(b)) {return false;}
if (Array.isArray(a) && Array.isArray(b)) { if (Array.isArray(a) && Array.isArray(b)) {
if (a.length !== b.length) return false; if (a.length !== b.length) {return false;}
return a.every((val, i) => deepEquals(val, b[i])); return a.every((val, i) => deepEquals(val, b[i]));
} }
const keysA = Object.keys(a) as (keyof T)[]; const keysA = Object.keys(a) as (keyof T)[];
const keysB = Object.keys(b) as (keyof T)[]; const keysB = Object.keys(b) as (keyof T)[];
if (keysA.length !== keysB.length) return false; if (keysA.length !== keysB.length) {return false;}
return keysA.every(key => deepEquals(a[key], b[key])); return keysA.every(key => deepEquals(a[key], b[key]));
} }

2
frontend/src/views/learning-paths/gift-adapters/essay-question-adapter.ts
View file

@ -3,7 +3,7 @@ export const essayQuestionAdapter: GiftAdapter = {
installListener(questionElement: Element, answerUpdateCallback: (newAnswer: string | number | object) => void): void { installListener(questionElement: Element, answerUpdateCallback: (newAnswer: string | number | object) => void): void {
const textArea = questionElement.querySelector('textarea')!; const textArea = questionElement.querySelector('textarea')!;
textArea.addEventListener('input', () => answerUpdateCallback(textArea.value)); textArea.addEventListener('input', () => { answerUpdateCallback(textArea.value); });
}, },
setAnswer(questionElement: Element, answer: string | number | object): void { setAnswer(questionElement: Element, answer: string | number | object): void {