refactor(frontend): Linting errors wegwerken

This commit is contained in:
Tibo De Peuter 2025-04-19 10:19:01 +02:00
parent e2ec28bbfb
commit a5e095b852
Signed by: tdpeuter
GPG key ID: 38297DE43F75FFE2
10 changed files with 72 additions and 69 deletions

View file

@ -9,7 +9,7 @@
import LearningObjectContentView from "@/views/learning-paths/learning-object/content/LearningObjectContentView.vue";
import LearningObjectSubmissionsView from "@/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue";
const isStudent = computed(() => authService.authState.activeRole === "student");
const _isStudent = computed(() => authService.authState.activeRole === "student");
const props = defineProps<{
hruid: string;

View file

@ -9,18 +9,19 @@
submissionData?: SubmissionData;
}>();
const emit = defineEmits<{
(e: "update:submissionData", value: SubmissionData): void;
}>();
const emit = defineEmits<(e: "update:submissionData", value: SubmissionData) => void>();
const submissionData = computed<SubmissionData | undefined>({
get: () => props.submissionData,
set: (v?: SubmissionData) => (v ? emit("update:submissionData", v) : undefined),
set: (v?: SubmissionData): void => {
if (v)
emit("update:submissionData", v)
},
});
function forEachQuestion(
doAction: (questionIndex: number, questionName: string, questionType: string, questionElement: Element) => void,
) {
): void {
const questions = document.querySelectorAll(".gift-question");
questions.forEach((question) => {
const name = question.id.match(/gift-q(\d+)/)?.[1];
@ -45,8 +46,8 @@
});
}
function setAnswers(answers: SubmissionData) {
forEachQuestion((index, name, type, element) => {
function setAnswers(answers: SubmissionData): void {
forEachQuestion((index, _name, type, element) => {
const answer = answers[index];
if (answer !== null && answer !== undefined) {
getGiftAdapterForType(type)?.setAnswer(element, answer);
@ -57,7 +58,7 @@
submissionData.value = answers;
}
onMounted(() =>
onMounted(async () =>
nextTick(() => {
attachQuestionListeners();
setAnswers(props.submissionData ?? []);

View file

@ -8,9 +8,7 @@
const props = defineProps<{
allSubmissions: SubmissionDTO[];
}>();
const emit = defineEmits<{
(e: "submission-selected", submission: SubmissionDTO): void;
}>();
const emit = defineEmits<(e: "submission-selected", submission: SubmissionDTO) => void>();
const headers = computed(() => [
{ title: "#", value: "submissionNo", width: "50px" },
@ -30,7 +28,7 @@
})),
);
function selectSubmission(submission: SubmissionDTO) {
function selectSubmission(submission: SubmissionDTO): void {
emit("submission-selected", submission);
}
</script>
@ -46,7 +44,7 @@
hide-default-footer
:no-data-text="t('noSubmissionsYet')"
>
<template v-slot:item.action="{ item }">
<template v-slot:[`item.action`]="{ item }">
<v-btn
density="compact"
variant="plain"

View file

@ -18,9 +18,7 @@
version: number;
group: { forGroup: number; assignmentNo: number; classId: string };
}>();
const emit = defineEmits<{
(e: "update:submissionData", value: SubmissionData): void;
}>();
const emit = defineEmits<(e: "update:submissionData", value: SubmissionData) => void>();
const submissionQuery = useSubmissionsQuery(
() => props.hruid,
@ -32,11 +30,11 @@
() => true,
);
function emitSubmissionData(submissionData: SubmissionData) {
function emitSubmissionData(submissionData: SubmissionData): void {
emit("update:submissionData", submissionData);
}
function emitSubmission(submission: SubmissionDTO) {
function emitSubmission(submission: SubmissionDTO): void {
emitSubmissionData(JSON.parse(submission.content));
}

View file

@ -25,9 +25,9 @@
const {
isPending: submissionIsPending,
isError: submissionFailed,
error: submissionError,
isSuccess: submissionSuccess,
// - isError: submissionFailed,
// - error: submissionError,
// - isSuccess: submissionSuccess,
mutate: submitSolution,
} = useCreateSubmissionMutation();
@ -47,11 +47,11 @@
});
function submitCurrentAnswer(): void {
const { forGroup, assignmentNo, classId } = props.group!;
const { forGroup, assignmentNo, classId } = props.group;
const currentUser: UserProfile = authService.authState.user!.profile;
const learningObjectIdentifier: LearningObjectIdentifierDTO = {
hruid: props.hruid,
language: props.language as Language,
language: props.language,
version: props.version,
};
const submitter: StudentDTO = {