From 762131ed3479ae1e776e24a6a42b9f2e751b4c28 Mon Sep 17 00:00:00 2001
From: Gerald Schmittinger <gerald.schmittinger@ugent.be>
Date: Tue, 20 May 2025 13:44:45 +0200
Subject: [PATCH] fix: Vragen stellen

---
 backend/src/data/questions/question-repository.ts      | 4 ++--
 frontend/src/components/QuestionBox.vue                | 1 -
 frontend/src/queries/questions.ts                      | 5 +++--
 frontend/src/views/learning-paths/LearningPathPage.vue | 7 +------
 4 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/backend/src/data/questions/question-repository.ts b/backend/src/data/questions/question-repository.ts
index a07a0a94..342751f2 100644
--- a/backend/src/data/questions/question-repository.ts
+++ b/backend/src/data/questions/question-repository.ts
@@ -18,8 +18,8 @@ export class QuestionRepository extends DwengoEntityRepository<Question> {
             content: question.content,
             timestamp: new Date(),
         });
-        console.log(questionEntity)
-        await this.save(questionEntity, { preventOverwrite: true });
+        // Don't check for overwrite since this is impossible anyway due to autoincrement.
+        await this.save(questionEntity, { preventOverwrite: false });
         return questionEntity;
     }
     public async findAllQuestionsAboutLearningObject(loId: LearningObjectIdentifier): Promise<Question[]> {
diff --git a/frontend/src/components/QuestionBox.vue b/frontend/src/components/QuestionBox.vue
index be5ea9ae..fa9bda21 100644
--- a/frontend/src/components/QuestionBox.vue
+++ b/frontend/src/components/QuestionBox.vue
@@ -54,7 +54,6 @@
 
 <template>
     <h3 v-if="props.withTitle && showQuestionBox">{{ t("askAQuestion") }}:</h3>
-    {{ props.forGroup }}
     <div
         class="question-box"
         v-if="showQuestionBox"
diff --git a/frontend/src/queries/questions.ts b/frontend/src/queries/questions.ts
index 920f41da..79d2f779 100644
--- a/frontend/src/queries/questions.ts
+++ b/frontend/src/queries/questions.ts
@@ -9,6 +9,7 @@ import {
     useQueryClient,
     type UseQueryReturnType,
 } from "@tanstack/vue-query";
+import type { Language } from "@dwengo-1/common/util/language";
 
 export function questionsQueryKey(
     loId: LearningObjectIdentifierDTO,
@@ -23,7 +24,7 @@ export function questionsGroupQueryKey(
     assignmentId: string,
     student: string,
     full: boolean,
-): [string, string, number, string, boolean] {
+): [string, string, number, Language, boolean, string, string, string] {
     return ["questions", loId.hruid, loId.version!, loId.language, full, classId, assignmentId, student];
 }
 
@@ -54,10 +55,10 @@ export function useQuestionsGroupQuery(
         queryKey: computed(() =>
             questionsGroupQueryKey(
                 toValue(loId),
-                toValue(full),
                 toValue(classId),
                 toValue(assignmentId),
                 toValue(student),
+                toValue(full),
             ),
         ),
         queryFn: async () =>
diff --git a/frontend/src/views/learning-paths/LearningPathPage.vue b/frontend/src/views/learning-paths/LearningPathPage.vue
index 4eb0331a..ce45d641 100644
--- a/frontend/src/views/learning-paths/LearningPathPage.vue
+++ b/frontend/src/views/learning-paths/LearningPathPage.vue
@@ -105,10 +105,6 @@
         );
     }
 
-    function refetchQuestions() {
-        getQuestionsQuery.refetch();
-    }
-
     const navigationDrawerShown = ref(true);
 
     function isLearningObjectCompleted(learningObject: LearningObject): boolean {
@@ -292,7 +288,7 @@
                 </v-list-item>
                 <v-list-item>
                     <div
-                        v-if="authService.authState.activeRole === AccountType.Student && pathIsAssignment"
+                        v-if="authService.authState.activeRole === AccountType.Student && forGroup"
                         class="assignment-indicator"
                     >
                         {{ t("assignmentIndicator") }}
@@ -358,7 +354,6 @@
                 :learningObjectLanguage="currentNode.language"
                 :learningObjectVersion="currentNode.version"
                 :forGroup="{assignment: forGroup.assignmentNo, class: forGroup.classId, groupNumber: forGroup.forGroup}"
-                @updated="refetchQuestions"
             />
             <QandA :questions="(questionsResponse.data.questions as QuestionDTO[]) ?? []" />
         </using-query-result>