From 705bce75e9db4905e929f8c73c8c3e281fafa441 Mon Sep 17 00:00:00 2001 From: Adriaan Jacquet Date: Sun, 18 May 2025 15:52:47 +0200 Subject: [PATCH] fix: req.query ipv req.params bij het authorizeren op root endpoint van submissions --- backend/src/middleware/auth/checks/submission-checks.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/src/middleware/auth/checks/submission-checks.ts b/backend/src/middleware/auth/checks/submission-checks.ts index bb0ad021..6c7969e0 100644 --- a/backend/src/middleware/auth/checks/submission-checks.ts +++ b/backend/src/middleware/auth/checks/submission-checks.ts @@ -31,15 +31,15 @@ export const onlyAllowIfHasAccessToSubmission = authorize(async (auth: Authentic }); export const onlyAllowIfHasAccessToSubmissionFromParams = authorize(async (auth: AuthenticationInfo, req: AuthenticatedRequest) => { - const { classId, assignmentId, groupId } = req.params; + const { classId, assignmentId, groupId } = req.query; requireFields({ classId, assignmentId, groupId }); if (auth.accountType === AccountType.Teacher) { - const cls = await fetchClass(classId); + const cls = await fetchClass(classId as string); return cls.teachers.map(mapToUsername).includes(auth.username); } - const group = await fetchGroup(classId, +assignmentId, +groupId); + const group = await fetchGroup(classId as string, +(assignmentId as string), +(groupId as string)); return group.members.map(mapToUsername).includes(auth.username); }); \ No newline at end of file