tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

refactor(backend): equality

Browse source
This commit is contained in:
Tibo De Peuter 2025-03-22 18:50:22 +01:00
parent 10d3d0567e
commit 6ad7fbf208
Signed by: tdpeuter
GPG key ID: 38297DE43F75FFE2
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
backend/src/services/class.ts
View file

@ -25,13 +25,13 @@ export async function createClass(classData: ClassDTO): Promise<Class | null> {
const teacherRepository = getTeacherRepository(); const teacherRepository = getTeacherRepository();
const teacherUsernames = classData.teachers || []; const teacherUsernames = classData.teachers || [];
const teachers = (await Promise.all(teacherUsernames.map(async (id) => teacherRepository.findByUsername(id)))).filter( const teachers = (await Promise.all(teacherUsernames.map(async (id) => teacherRepository.findByUsername(id)))).filter(
(teacher) => teacher != null (teacher) => teacher !== null
); );
const studentRepository = getStudentRepository(); const studentRepository = getStudentRepository();
const studentUsernames = classData.students || []; const studentUsernames = classData.students || [];
const students = (await Promise.all(studentUsernames.map(async (id) => studentRepository.findByUsername(id)))).filter( const students = (await Promise.all(studentUsernames.map(async (id) => studentRepository.findByUsername(id)))).filter(
(student) => student != null (student) => student !== null
); );
//Const cls = mapToClass(classData, teachers, students); //Const cls = mapToClass(classData, teachers, students);

2
backend/src/services/groups.ts
View file

@ -44,7 +44,7 @@ export async function createGroup(groupData: GroupDTO, classid: string, assignme
const memberUsernames = (groupData.members as string[]) || []; // TODO check if groupdata.members is a list const memberUsernames = (groupData.members as string[]) || []; // TODO check if groupdata.members is a list
const members = (await Promise.all([...memberUsernames].map(async (id) => studentRepository.findByUsername(id)))).filter( const members = (await Promise.all([...memberUsernames].map(async (id) => studentRepository.findByUsername(id)))).filter(
(student) => student != null (student) => student !== null
); );
getLogger().debug(members); getLogger().debug(members);

2
backend/tests/data/questions/answers.test.ts
View file

@ -23,7 +23,7 @@ describe('AnswerRepository', () => {
const id = new LearningObjectIdentifier('id05', Language.English, 1); const id = new LearningObjectIdentifier('id05', Language.English, 1);
const questions = await questionRepository.findAllQuestionsAboutLearningObject(id); const questions = await questionRepository.findAllQuestionsAboutLearningObject(id);
const question = questions.filter((it) => it.sequenceNumber == 2)[0]; const question = questions.filter((it) => it.sequenceNumber === 2)[0];
const answers = await answerRepository.findAllAnswersToQuestion(question); const answers = await answerRepository.findAllAnswersToQuestion(question);