tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

fix(backend): Commentaar in PR geaddresseerd.

Browse source
This commit is contained in:
Gerald Schmittinger 2025-03-12 19:45:18 +01:00
parent e3e6a03003
commit 699ebf62b8
2 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
backend/src/services/learning-objects/dwengo-api-learning-object-provider.ts
View file

@ -65,14 +65,15 @@ async function fetchLearningObjects(learningPathId: LearningPathIdentifier, full
return nodes.map((node) => node.learningobject_hruid); return nodes.map((node) => node.learningobject_hruid);
} }
return await Promise.all( const objects = await Promise.all(
nodes.map(async (node) => nodes.map(async (node) =>
dwengoApiLearningObjectProvider.getLearningObjectById({ dwengoApiLearningObjectProvider.getLearningObjectById({
hruid: node.learningobject_hruid, hruid: node.learningobject_hruid,
language: learningPathId.language, language: learningPathId.language,
}) })
) )
).then((objects) => objects.filter((obj): obj is FilteredLearningObject => obj !== null)); );
return objects.filter((obj): obj is FilteredLearningObject => obj !== null);
} catch (error) { } catch (error) {
logger.error('❌ Error fetching learning objects:', error); logger.error('❌ Error fetching learning objects:', error);
return []; return [];

8
backend/tests/services/learning-objects/learning-object-service.test.ts
View file

@ -10,7 +10,6 @@ import { EnvVars, getEnvVar } from '../../../src/util/envvars';
import { LearningPath } from '../../../src/entities/content/learning-path.entity'; import { LearningPath } from '../../../src/entities/content/learning-path.entity';
import learningPathExample from '../../test-assets/learning-paths/pn-werking-example'; import learningPathExample from '../../test-assets/learning-paths/pn-werking-example';
const TEST_LEARNING_OBJECT_TITLE = 'Test title';
const EXPECTED_DWENGO_LEARNING_OBJECT_TITLE = 'Werken met notebooks'; const EXPECTED_DWENGO_LEARNING_OBJECT_TITLE = 'Werken met notebooks';
const DWENGO_TEST_LEARNING_OBJECT_ID: LearningObjectIdentifier = { const DWENGO_TEST_LEARNING_OBJECT_ID: LearningObjectIdentifier = {
hruid: 'pn_werkingnotebooks', hruid: 'pn_werkingnotebooks',
@ -78,11 +77,12 @@ describe('LearningObjectService', () => {
const result = await learningObjectService.getLearningObjectHTML(DWENGO_TEST_LEARNING_OBJECT_ID); const result = await learningObjectService.getLearningObjectHTML(DWENGO_TEST_LEARNING_OBJECT_ID);
expect(result).not.toBeNull(); expect(result).not.toBeNull();
const htmlFromDwengoApi = await fetch( const responseFromDwengoApi = await fetch(
getEnvVar(EnvVars.LearningContentRepoApiBaseUrl) + getEnvVar(EnvVars.LearningContentRepoApiBaseUrl) +
`/learningObject/getRaw?hruid=${DWENGO_TEST_LEARNING_OBJECT_ID.hruid}&language=${DWENGO_TEST_LEARNING_OBJECT_ID.language}&version=${DWENGO_TEST_LEARNING_OBJECT_ID.version}` `/learningObject/getRaw?hruid=${DWENGO_TEST_LEARNING_OBJECT_ID.hruid}&language=${DWENGO_TEST_LEARNING_OBJECT_ID.language}&version=${DWENGO_TEST_LEARNING_OBJECT_ID.version}`
).then((it) => it.text()); );
expect(result).toEqual(htmlFromDwengoApi); const responseHtml = await responseFromDwengoApi.text();
expect(result).toEqual(responseHtml);
} }
); );
it('returns null when queried with a non-existing identifier', async () => { it('returns null when queried with a non-existing identifier', async () => {