tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

feat(frontend): linter errors fixen

Browse source
This commit is contained in:
Joyelle Ndagijimana 2025-04-20 17:15:56 +02:00
parent c68f0872bf
commit 5bb75ebdf8
3 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
frontend/src/views/assignments/SingleAssignment.vue
View file

@ -1,7 +1,7 @@
<script setup lang="ts">
import auth from "@/services/auth/auth-service.ts";
import {computed, reactive, type Ref, ref, watchEffect} from "vue";
import {computed, type Ref, ref, watchEffect} from "vue";
import StudentAssignment from "@/views/assignments/StudentAssignment.vue";
import TeacherAssignment from "@/views/assignments/TeacherAssignment.vue";
import {useRoute} from "vue-router";
@ -21,14 +21,12 @@ function useGroupsWithProgress(
groups: Ref<GroupDTO[]>,
hruid: Ref<string>,
language: Ref<string>
): { groupProgressMap: Record<number, number> } {
const groupProgressMap: Record<number, number> = reactive({});
): { groupProgressMap: Map<number, number> } {
const groupProgressMap: Map<number, number> = new Map<number, number>();
watchEffect(() => {
// Clear existing entries to avoid stale data
for (const key in groupProgressMap) {
delete groupProgressMap[key];
}
groupProgressMap.clear();
const lang = ref(language.value as Language);
@ -44,7 +42,7 @@ function useGroupsWithProgress(
const data = query.data.value;
groupProgressMap[groupKey] = data ? calculateProgress(data) : 0;
groupProgressMap.set(groupKey, data ? calculateProgress(data) : 0);
});
});

4
frontend/src/views/assignments/StudentAssignment.vue
View file

@ -19,7 +19,7 @@ const props = defineProps<{
groups: Ref<GroupDTO[]>,
hruid: Ref<string>,
language: Ref<Language>
) => { groupProgressMap: Record<string, number> };
) => { groupProgressMap: Map<number, number> };
}>();
const {t, locale} = useI18n();
@ -50,7 +50,7 @@ const group = computed(() =>
);
const groupArray = computed(() => (group.value ? [group.value] : []));
const _groupArray = computed(() => (group.value ? [group.value] : []));
const progressValue = ref(0);
/* Crashes right now cause api data has inexistent hruid TODO: uncomment later and use it in progress bar
Const {groupProgressMap} = props.useGroupsWithProgress(

8
frontend/src/views/assignments/TeacherAssignment.vue
View file

@ -17,7 +17,7 @@ const props = defineProps<{
groups: Ref<GroupDTO[]>,
hruid: Ref<string>,
language: Ref<Language>
) => { groupProgressMap: Record<string, number> };
) => { groupProgressMap: Map<number, number> };
}>();
const {t, locale} = useI18n();
@ -143,13 +143,13 @@ async function deleteAssignment(num: number, clsId: string): Promise<void> {
item-key="id"
class="elevation-1"
>
<template v-slot:item.name="{ item }">
<template #[`item.name`]="{ item }">
<v-btn @click="openGroupDetails(item)" variant="text" color="primary">
{{ item.name }}
</v-btn>
</template>
<template v-slot:item.progress="{ item }">
<template #[`item.progress`]="{ item }">
<v-progress-linear
:model-value="item.progress"
color="blue-grey"
@ -161,7 +161,7 @@ async function deleteAssignment(num: number, clsId: string): Promise<void> {
</v-progress-linear>
</template>
<template v-slot:item.submission="{ item }">
<template #[`item.submission`]="{ item }">
<v-btn
:to="item.submitted ? `${props.assignmentId}/submissions/` : undefined"
:color="item.submitted ? 'green' : 'red'"