From 7d80c8bdc12f70db826b3817907ac7ebae594675 Mon Sep 17 00:00:00 2001 From: laurejablonski Date: Tue, 20 May 2025 09:27:27 +0200 Subject: [PATCH 1/8] feat: enkel content scrollable, niet titels, knoppen, ... --- .../src/components/DiscussionsSideBar.vue | 34 ++++++++++++------- .../views/learning-paths/LearningPathPage.vue | 8 ++++- 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/frontend/src/components/DiscussionsSideBar.vue b/frontend/src/components/DiscussionsSideBar.vue index 5c68e6ac..9c54ced4 100644 --- a/frontend/src/components/DiscussionsSideBar.vue +++ b/frontend/src/components/DiscussionsSideBar.vue @@ -34,19 +34,21 @@ - - - - - +
+ + + + + +
@@ -67,4 +69,10 @@ padding-top: 2%; font-size: 36px; } + + .nav-scroll-area { + overflow-y: auto; + flex-grow: 1; + min-height: 0; + } diff --git a/frontend/src/views/learning-paths/LearningPathPage.vue b/frontend/src/views/learning-paths/LearningPathPage.vue index c41f6063..01e48336 100644 --- a/frontend/src/views/learning-paths/LearningPathPage.vue +++ b/frontend/src/views/learning-paths/LearningPathPage.vue @@ -229,7 +229,7 @@ -
+
From 4a7b321b53eafd43df62311dde6cc65f924fcb77 Mon Sep 17 00:00:00 2001 From: laurejablonski Date: Tue, 20 May 2025 11:19:18 +0200 Subject: [PATCH 2/8] fix: submissions en assignments veiliger opvragen --- backend/src/services/submissions.ts | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/backend/src/services/submissions.ts b/backend/src/services/submissions.ts index 1170bf50..c2fd8b0e 100644 --- a/backend/src/services/submissions.ts +++ b/backend/src/services/submissions.ts @@ -4,9 +4,10 @@ import { NotFoundException } from '../exceptions/not-found-exception.js'; import { mapToSubmission, mapToSubmissionDTO } from '../interfaces/submission.js'; import { SubmissionDTO } from '@dwengo-1/common/interfaces/submission'; import { fetchStudent } from './students.js'; -import { getExistingGroupFromGroupDTO } from './groups.js'; +import { fetchGroup, getExistingGroupFromGroupDTO } from './groups.js'; import { Submission } from '../entities/assignments/submission.entity.js'; import { Language } from '@dwengo-1/common/util/language'; +import { fetchAssignment } from './assignments.js'; export async function fetchSubmission(loId: LearningObjectIdentifier, submissionNumber: number): Promise { const submissionRepository = getSubmissionRepository(); @@ -64,15 +65,18 @@ export async function getSubmissionsForLearningObjectAndAssignment( groupId?: number ): Promise { const loId = new LearningObjectIdentifier(learningObjectHruid, language, version); - const assignment = await getAssignmentRepository().findByClassIdAndAssignmentId(classId, assignmentId); - let submissions: Submission[]; - if (groupId !== undefined) { - const group = await getGroupRepository().findByAssignmentAndGroupNumber(assignment!, groupId); - submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndGroup(loId, group!); - } else { - submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment!); + try { + let submissions: Submission[]; + if (groupId !== undefined) { + const group = await fetchGroup(classId, assignmentId, groupId!); + submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndGroup(loId, group!); + } else { + const assignment = await fetchAssignment(classId, assignmentId); + submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment!); + } + return submissions.map((s) => mapToSubmissionDTO(s)); + } catch(e) { + return []; } - - return submissions.map((s) => mapToSubmissionDTO(s)); } From c7c3a209e1026e1a0d6d8d781f4650ecc65c6ffc Mon Sep 17 00:00:00 2001 From: laurejablonski Date: Tue, 20 May 2025 11:19:34 +0200 Subject: [PATCH 3/8] fix: dubbel punt moet niet in link --- frontend/src/controllers/questions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/controllers/questions.ts b/frontend/src/controllers/questions.ts index 86f4a56d..61d048f5 100644 --- a/frontend/src/controllers/questions.ts +++ b/frontend/src/controllers/questions.ts @@ -14,7 +14,7 @@ export class QuestionController extends BaseController { loId: LearningObjectIdentifierDTO; constructor(loId: LearningObjectIdentifierDTO) { - super(`learningObject/${loId.hruid}/:${loId.version}/questions`); + super(`learningObject/${loId.hruid}/${loId.version}/questions`); this.loId = loId; } From 66ac71c6cb1c8283943f3d656c4b9571a18b0672 Mon Sep 17 00:00:00 2001 From: laurejablonski Date: Tue, 20 May 2025 11:19:55 +0200 Subject: [PATCH 4/8] fix: verwijder onnodige queries --- .../views/learning-paths/LearningPathPage.vue | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/frontend/src/views/learning-paths/LearningPathPage.vue b/frontend/src/views/learning-paths/LearningPathPage.vue index 01e48336..a7ac9a51 100644 --- a/frontend/src/views/learning-paths/LearningPathPage.vue +++ b/frontend/src/views/learning-paths/LearningPathPage.vue @@ -13,13 +13,11 @@ import authService from "@/services/auth/auth-service.ts"; import { LearningPathNode } from "@/data-objects/learning-paths/learning-path-node.ts"; import LearningPathGroupSelector from "@/views/learning-paths/LearningPathGroupSelector.vue"; - import { useCreateQuestionMutation, useQuestionsQuery } from "@/queries/questions"; + import { useQuestionsQuery } from "@/queries/questions"; import type { QuestionsResponse } from "@/controllers/questions"; import type { LearningObjectIdentifierDTO } from "@dwengo-1/common/interfaces/learning-content"; import QandA from "@/components/QandA.vue"; import type { QuestionDTO } from "@dwengo-1/common/interfaces/question"; - import { useStudentAssignmentsQuery, useStudentGroupsQuery } from "@/queries/students"; - import type { AssignmentDTO } from "@dwengo-1/common/interfaces/assignment"; import QuestionNotification from "@/components/QuestionNotification.vue"; import QuestionBox from "@/components/QuestionBox.vue"; import { AccountType } from "@dwengo-1/common/util/account-types"; @@ -147,19 +145,6 @@ }); } - const studentAssignmentsQueryResult = useStudentAssignmentsQuery( - authService.authState.user?.profile.preferred_username, - ); - - const loID: LearningObjectIdentifierDTO = { - hruid: props.learningObjectHruid as string, - language: props.language, - }; - const createQuestionMutation = useCreateQuestionMutation(loID); - const groupsQueryResult = useStudentGroupsQuery(authService.authState.user?.profile.preferred_username); - - const questionInput = ref(""); - const discussionLink = computed( () => "/discussion" + From e7fa469bde3952bef95f83bc86f563b8fb3ea103 Mon Sep 17 00:00:00 2001 From: laurejablonski Date: Tue, 20 May 2025 11:21:09 +0200 Subject: [PATCH 5/8] fix: json syntax error --- .../LearningObjectSubmissionsView.vue | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue b/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue index 5a7fa9d2..088d87da 100644 --- a/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue +++ b/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue @@ -18,6 +18,15 @@ version: number; group: { forGroup: number; assignmentNo: number; classId: string }; }>(); + + function parseContent(content: string): SubmissionData { + if (content === "") { + return []; + } + + return JSON.parse(content); + } + const emit = defineEmits<(e: "update:submissionData", value: SubmissionData) => void>(); const submissionQuery = useSubmissionsQuery( @@ -35,7 +44,7 @@ } function emitSubmission(submission: SubmissionDTO): void { - emitSubmissionData(JSON.parse(submission.content)); + emitSubmissionData(parseContent(submission.content)); } watch(submissionQuery.data, () => { @@ -47,12 +56,13 @@ } }); - const lastSubmission = computed(() => { + const lastSubmission = computed(() => { const submissions = submissionQuery.data.value; if (!submissions || submissions.length === 0) { return undefined; } - return JSON.parse(submissions[submissions.length - 1].content); + + return parseContent(submissions[submissions.length - 1].content); }); const showSubmissionTable = computed(() => props.submissionData !== undefined && props.submissionData.length > 0); From 3867151a05ef59df081773e715b3eeb9cc32a771 Mon Sep 17 00:00:00 2001 From: Lint Action Date: Tue, 20 May 2025 09:23:50 +0000 Subject: [PATCH 6/8] style: fix linting issues met ESLint --- backend/src/services/submissions.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/src/services/submissions.ts b/backend/src/services/submissions.ts index c2fd8b0e..28e82d5d 100644 --- a/backend/src/services/submissions.ts +++ b/backend/src/services/submissions.ts @@ -69,11 +69,11 @@ export async function getSubmissionsForLearningObjectAndAssignment( try { let submissions: Submission[]; if (groupId !== undefined) { - const group = await fetchGroup(classId, assignmentId, groupId!); - submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndGroup(loId, group!); + const group = await fetchGroup(classId, assignmentId, groupId); + submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndGroup(loId, group); } else { const assignment = await fetchAssignment(classId, assignmentId); - submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment!); + submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment); } return submissions.map((s) => mapToSubmissionDTO(s)); } catch(e) { From 4604a8200d639b32fc7b794366cd96eeb6cb0efa Mon Sep 17 00:00:00 2001 From: Lint Action Date: Tue, 20 May 2025 09:23:57 +0000 Subject: [PATCH 7/8] style: fix linting issues met Prettier --- backend/src/services/submissions.ts | 2 +- .../submissions/LearningObjectSubmissionsView.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/src/services/submissions.ts b/backend/src/services/submissions.ts index 28e82d5d..9f7e11d1 100644 --- a/backend/src/services/submissions.ts +++ b/backend/src/services/submissions.ts @@ -76,7 +76,7 @@ export async function getSubmissionsForLearningObjectAndAssignment( submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment); } return submissions.map((s) => mapToSubmissionDTO(s)); - } catch(e) { + } catch (e) { return []; } } diff --git a/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue b/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue index 088d87da..7b220b04 100644 --- a/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue +++ b/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue @@ -56,7 +56,7 @@ } }); - const lastSubmission = computed(() => { + const lastSubmission = computed(() => { const submissions = submissionQuery.data.value; if (!submissions || submissions.length === 0) { return undefined; From 6022c36bb620e49a855573a872e87f99088cd8c5 Mon Sep 17 00:00:00 2001 From: laurejablonski Date: Tue, 20 May 2025 11:26:24 +0200 Subject: [PATCH 8/8] style: format en lint --- backend/src/services/submissions.ts | 10 +++++----- .../submissions/LearningObjectSubmissionsView.vue | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backend/src/services/submissions.ts b/backend/src/services/submissions.ts index c2fd8b0e..90b245e3 100644 --- a/backend/src/services/submissions.ts +++ b/backend/src/services/submissions.ts @@ -1,4 +1,4 @@ -import { getAssignmentRepository, getGroupRepository, getSubmissionRepository } from '../data/repositories.js'; +import { getSubmissionRepository } from '../data/repositories.js'; import { LearningObjectIdentifier } from '../entities/content/learning-object-identifier.js'; import { NotFoundException } from '../exceptions/not-found-exception.js'; import { mapToSubmission, mapToSubmissionDTO } from '../interfaces/submission.js'; @@ -69,14 +69,14 @@ export async function getSubmissionsForLearningObjectAndAssignment( try { let submissions: Submission[]; if (groupId !== undefined) { - const group = await fetchGroup(classId, assignmentId, groupId!); - submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndGroup(loId, group!); + const group = await fetchGroup(classId, assignmentId, groupId); + submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndGroup(loId, group); } else { const assignment = await fetchAssignment(classId, assignmentId); - submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment!); + submissions = await getSubmissionRepository().findAllSubmissionsForLearningObjectAndAssignment(loId, assignment); } return submissions.map((s) => mapToSubmissionDTO(s)); - } catch(e) { + } catch (_) { return []; } } diff --git a/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue b/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue index 088d87da..7b220b04 100644 --- a/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue +++ b/frontend/src/views/learning-paths/learning-object/submissions/LearningObjectSubmissionsView.vue @@ -56,7 +56,7 @@ } }); - const lastSubmission = computed(() => { + const lastSubmission = computed(() => { const submissions = submissionQuery.data.value; if (!submissions || submissions.length === 0) { return undefined;