tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

refactor: Cleanup

Browse source
This commit is contained in:
Tibo De Peuter 2025-03-23 14:02:11 +01:00
parent 4bf82b09fa
commit 413220c54f
Signed by: tdpeuter
GPG key ID: 38297DE43F75FFE2
9 changed files with 53 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
backend/src/controllers/assignments.ts
View file

@ -2,7 +2,7 @@ import { Request, Response } from 'express';
import { createAssignment, getAllAssignments, getAssignment, getAssignmentsSubmissions } from '../services/assignments.js';
import { AssignmentDTO } from '../interfaces/assignment.js';
// Typescript is annoy with with parameter forwarding from class.ts
// Typescript is annoying with parameter forwarding from class.ts
interface AssignmentParams {
classid: string;
id: string;

2
backend/src/controllers/groups.ts
View file

@ -80,7 +80,7 @@ export async function getGroupSubmissionsHandler(req: Request, res: Response): P
return;
}
const groupId = Number(req.params.groupid!); // Can't be undefined
const groupId = Number(req.params.groupid); // Can't be undefined
if (isNaN(groupId)) {
res.status(400).json({ error: 'Group id must be a number' });

10
backend/src/controllers/themes.ts
View file

@ -3,18 +3,16 @@ import { themes } from '../data/themes.js';
import { loadTranslations } from '../util/translation-helper.js';
interface Translations {
curricula_page: {
[key: string]: { title: string; description?: string };
};
curricula_page: Record<string, { title: string; description?: string }>;
}
export function getThemes(req: Request, res: Response): void {
const language = (req.query.language as string)?.toLowerCase() || 'nl';
const language = (req.query.language as string).toLowerCase() || 'nl';
const translations = loadTranslations<Translations>(language);
const themeList = themes.map((theme) => ({
key: theme.title,
title: translations.curricula_page[theme.title]?.title || theme.title,
description: translations.curricula_page[theme.title]?.description,
title: translations.curricula_page[theme.title].title || theme.title,
description: translations.curricula_page[theme.title].description,
image: `https://dwengo.org/images/curricula/logo_${theme.title}.png`,
}));

2
backend/src/services/learning-paths/database-learning-path-provider.ts
View file

@ -25,7 +25,7 @@ async function getLearningObjectsForNodes(nodes: LearningPathNode[]): Promise<Ma
version: node.version,
language: node.language,
})
.then((learningObject) => ([node, learningObject] as [LearningPathNode, FilteredLearningObject | null]))
.then((learningObject) => [node, learningObject] as [LearningPathNode, FilteredLearningObject | null])
)
)
);