From 2ac1b8187cfffd1e1d42f29610892de20a71297c Mon Sep 17 00:00:00 2001
From: Gabriellvl <vanlangenhovefga@gmail.com>
Date: Mon, 19 May 2025 17:44:13 +0200
Subject: [PATCH] fix: imports + extra error type try and catch

---
 backend/src/services/assignments.ts | 5 +++--
 backend/src/services/students.ts    | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/backend/src/services/assignments.ts b/backend/src/services/assignments.ts
index 5a4d3fcd..b4455cfa 100644
--- a/backend/src/services/assignments.ts
+++ b/backend/src/services/assignments.ts
@@ -19,7 +19,8 @@ import { putObject } from './service-helper.js';
 import { fetchStudents } from './students.js';
 import { ServerErrorException } from '../exceptions/server-error-exception.js';
 import { BadRequestException } from '../exceptions/bad-request-exception.js';
-import { ConflictException } from '../exceptions/conflict-exception';
+import { ConflictException } from '../exceptions/conflict-exception.js';
+import { PostgreSqlExceptionConverter } from "@mikro-orm/postgresql";
 
 export async function fetchAssignment(classid: string, assignmentNumber: number): Promise<Assignment> {
     const classRepository = getClassRepository();
@@ -138,7 +139,7 @@ export async function deleteAssignment(classid: string, id: number): Promise<Ass
     try {
         await assignmentRepository.deleteByClassAndId(cls, id);
     } catch (e: unknown) {
-        if (e instanceof ForeignKeyConstraintViolationException) {
+        if (e instanceof ForeignKeyConstraintViolationException || e instanceof PostgreSqlExceptionConverter) {
             throw new ConflictException('Cannot delete assigment with questions or submissions');
         } else {
             throw e;
diff --git a/backend/src/services/students.ts b/backend/src/services/students.ts
index a80a0580..9050e278 100644
--- a/backend/src/services/students.ts
+++ b/backend/src/services/students.ts
@@ -26,7 +26,7 @@ import { ClassJoinRequestDTO } from '@dwengo-1/common/interfaces/class-join-requ
 import { ConflictException } from '../exceptions/conflict-exception.js';
 import { Submission } from '../entities/assignments/submission.entity.js';
 import { mapToUsername } from '../interfaces/user.js';
-import { mapToAssignmentDTO, mapToAssignmentDTOId } from '../interfaces/assignment';
+import { mapToAssignmentDTO, mapToAssignmentDTOId } from '../interfaces/assignment.js';
 
 export async function getAllStudents(full: boolean): Promise<StudentDTO[] | string[]> {
     const studentRepository = getStudentRepository();