From 293c51bab33e9b8ae1073ead8618fe805ec27217 Mon Sep 17 00:00:00 2001 From: Tibo De Peuter Date: Sun, 23 Mar 2025 12:32:41 +0100 Subject: [PATCH] refactor(frontend): Verwijder console logs --- frontend/src/components/MenuBar.vue | 1 - frontend/src/services/auth/auth-config-loader.ts | 2 +- frontend/src/services/auth/auth-service.ts | 9 ++++----- frontend/src/services/auth/auth.d.ts | 5 ++++- frontend/src/views/CallbackPage.vue | 4 ++-- 5 files changed, 11 insertions(+), 10 deletions(-) diff --git a/frontend/src/components/MenuBar.vue b/frontend/src/components/MenuBar.vue index 95468351..b5ea4fdb 100644 --- a/frontend/src/components/MenuBar.vue +++ b/frontend/src/components/MenuBar.vue @@ -32,7 +32,6 @@ function changeLanguage(langCode: string): void { locale.value = langCode; localStorage.setItem("user-lang", langCode); - console.log(langCode); } diff --git a/frontend/src/services/auth/auth-config-loader.ts b/frontend/src/services/auth/auth-config-loader.ts index 05e2f537..4f2db497 100644 --- a/frontend/src/services/auth/auth-config-loader.ts +++ b/frontend/src/services/auth/auth-config-loader.ts @@ -1,6 +1,6 @@ import apiClient from "@/services/api-client.ts"; import type { FrontendAuthConfig } from "@/services/auth/auth.d.ts"; -import type {UserManagerSettings} from "oidc-client-ts"; +import type { UserManagerSettings } from "oidc-client-ts"; /** * Fetch the authentication configuration from the backend. diff --git a/frontend/src/services/auth/auth-service.ts b/frontend/src/services/auth/auth-service.ts index 60765a5a..a7aa2507 100644 --- a/frontend/src/services/auth/auth-service.ts +++ b/frontend/src/services/auth/auth-service.ts @@ -80,15 +80,14 @@ async function handleLoginCallback(): Promise { async function renewToken(): Promise { const activeRole = authStorage.getActiveRole(); if (!activeRole) { - console.log("Can't renew the token: Not logged in!"); + // FIXME console.log("Can't renew the token: Not logged in!"); await initiateLogin(); return null; } try { return await (await getUserManagers())[activeRole].signinSilent(); - } catch (error) { - console.log("Can't renew the token:"); - console.log(error); + } catch (_error) { + // FIXME console.log("Can't renew the token: " + error); await initiateLogin(); } return null; @@ -123,7 +122,7 @@ apiClient.interceptors.response.use( async (error: AxiosError<{ message?: string }>) => { if (error.response?.status === 401) { if (error.response.data.message === "token_expired") { - console.log("Access token expired, trying to refresh..."); + // FIXME console.log("Access token expired, trying to refresh..."); await renewToken(); return apiClient(error.config!); // Retry the request } // Apparently, the user got a 401 because he was not logged in yet at all. Redirect him to login. diff --git a/frontend/src/services/auth/auth.d.ts b/frontend/src/services/auth/auth.d.ts index d8c5990f..85322431 100644 --- a/frontend/src/services/auth/auth.d.ts +++ b/frontend/src/services/auth/auth.d.ts @@ -19,4 +19,7 @@ export interface FrontendIdpConfig { } export type Role = "student" | "teacher"; -export interface UserManagersForRoles { student: UserManager; teacher: UserManager } +export interface UserManagersForRoles { + student: UserManager; + teacher: UserManager; +} diff --git a/frontend/src/views/CallbackPage.vue b/frontend/src/views/CallbackPage.vue index 306dfe10..fd3fd15d 100644 --- a/frontend/src/views/CallbackPage.vue +++ b/frontend/src/views/CallbackPage.vue @@ -9,8 +9,8 @@ try { await auth.handleLoginCallback(); await router.replace("/"); // Redirect to home (or dashboard) - } catch (error) { - console.error("OIDC callback error:", error); + } catch (_error) { + // FIXME console.error("OIDC callback error:", error); } });