tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
Archived
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

fix: check student in klas, conflict error

Browse source
This commit is contained in:
Gabriellvl 2025-04-07 23:48:35 +02:00
parent 3f74c3491f
commit 12d21f3c49
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
backend/src/services/students.ts
View file

@ -23,6 +23,8 @@ import { GroupDTO } from '@dwengo-1/common/interfaces/group';
import { SubmissionDTO, SubmissionDTOId } from '@dwengo-1/common/interfaces/submission'; import { SubmissionDTO, SubmissionDTOId } from '@dwengo-1/common/interfaces/submission';
import { QuestionDTO, QuestionId } from '@dwengo-1/common/interfaces/question'; import { QuestionDTO, QuestionId } from '@dwengo-1/common/interfaces/question';
import { ClassJoinRequestDTO } from '@dwengo-1/common/interfaces/class-join-request'; import { ClassJoinRequestDTO } from '@dwengo-1/common/interfaces/class-join-request';
import {BadRequestException} from "../exceptions/bad-request-exception";
import {ConflictException} from "../exceptions/conflict-exception";
export async function getAllStudents(full: boolean): Promise<StudentDTO[] | string[]> { export async function getAllStudents(full: boolean): Promise<StudentDTO[] | string[]> {
const studentRepository = getStudentRepository(); const studentRepository = getStudentRepository();
@ -135,6 +137,10 @@ export async function createClassJoinRequest(username: string, classId: string):
const student = await fetchStudent(username); // Throws error if student not found const student = await fetchStudent(username); // Throws error if student not found
const cls = await fetchClass(classId); const cls = await fetchClass(classId);
if (cls.students.contains(student)) {
throw new ConflictException("Student already in this class");
}
const request = mapToStudentRequest(student, cls); const request = mapToStudentRequest(student, cls);
await requestRepo.save(request, { preventOverwrite: true }); await requestRepo.save(request, { preventOverwrite: true });
return mapToStudentRequestDTO(request); return mapToStudentRequestDTO(request);