refactor(backend): no-implicit-coercion

backend/src/controllers/assignments.ts

@@ -41,7 +41,7 @@ export async function createAssignmentHandler(req: Request<AssignmentParams>, re
 }
 
 export async function getAssignmentHandler(req: Request<AssignmentParams>, res: Response): Promise<void> {
-    const id = +req.params.id;
+    const id = Number(req.params.id);
     const classid = req.params.classid;
 
     if (isNaN(id)) {
@@ -61,7 +61,7 @@ export async function getAssignmentHandler(req: Request<AssignmentParams>, res:
 
 export async function getAssignmentsSubmissionsHandler(req: Request<AssignmentParams>, res: Response): Promise<void> {
     const classid = req.params.classid;
-    const assignmentNumber = +req.params.id;
+    const assignmentNumber = Number(req.params.id);
 
     if (isNaN(assignmentNumber)) {
         res.status(400).json({ error: 'Assignment id must be a number' });

backend/src/controllers/groups.ts

@@ -12,14 +12,14 @@ interface GroupParams {
 export async function getGroupHandler(req: Request<GroupParams>, res: Response): Promise<void> {
     const classId = req.params.classid;
     const full = req.query.full === 'true';
-    const assignmentId = +req.params.assignmentid;
+    const assignmentId = Number(req.params.assignmentid);
 
     if (isNaN(assignmentId)) {
         res.status(400).json({ error: 'Assignment id must be a number' });
         return;
     }
 
-    const groupId = +req.params.groupid!; // Can't be undefined
+    const groupId = Number(req.params.groupid!); // Can't be undefined
 
     if (isNaN(groupId)) {
         res.status(400).json({ error: 'Group id must be a number' });
@@ -35,7 +35,7 @@ export async function getAllGroupsHandler(req: Request, res: Response): Promise<
     const classId = req.params.classid;
     const full = req.query.full === 'true';
 
-    const assignmentId = +req.params.assignmentid;
+    const assignmentId = Number(req.params.assignmentid);
 
     if (isNaN(assignmentId)) {
         res.status(400).json({ error: 'Assignment id must be a number' });
@@ -51,7 +51,7 @@ export async function getAllGroupsHandler(req: Request, res: Response): Promise<
 
 export async function createGroupHandler(req: Request, res: Response): Promise<void> {
     const classid = req.params.classid;
-    const assignmentId = +req.params.assignmentid;
+    const assignmentId = Number(req.params.assignmentid);
 
     if (isNaN(assignmentId)) {
         res.status(400).json({ error: 'Assignment id must be a number' });
@@ -73,14 +73,14 @@ export async function getGroupSubmissionsHandler(req: Request, res: Response): P
     const classId = req.params.classid;
     // Const full = req.query.full === 'true';
 
-    const assignmentId = +req.params.assignmentid;
+    const assignmentId = Number(req.params.assignmentid);
 
     if (isNaN(assignmentId)) {
         res.status(400).json({ error: 'Assignment id must be a number' });
         return;
     }
 
-    const groupId = +req.params.groupid!; // Can't be undefined
+    const groupId = Number(req.params.groupid!); // Can't be undefined
 
     if (isNaN(groupId)) {
         res.status(400).json({ error: 'Group id must be a number' });

backend/src/controllers/questions.ts

@@ -17,7 +17,7 @@ function getObjectId(req: Request, res: Response): LearningObjectIdentifier | nu
     return {
         hruid,
         language: (lang as Language) || FALLBACK_LANG,
-        version: +version,
+        version: Number(version),
     };
 }
 

backend/src/controllers/submissions.ts

@@ -10,7 +10,7 @@ interface SubmissionParams {
 
 export async function getSubmissionHandler(req: Request<SubmissionParams>, res: Response): Promise<void> {
     const lohruid = req.params.hruid;
-    const submissionNumber = +req.params.id;
+    const submissionNumber = Number(req.params.id);
 
     if (isNaN(submissionNumber)) {
         res.status(400).json({ error: 'Submission number is not a number' });
@@ -44,7 +44,7 @@ export async function createSubmissionHandler(req: Request, res: Response): Prom
 
 export async function deleteSubmissionHandler(req: Request, res: Response): Promise<void> {
     const hruid = req.params.hruid;
-    const submissionNumber = +req.params.id;
+    const submissionNumber = Number(req.params.id);
 
     const lang = languageMap[req.query.language as string] || Language.Dutch;
     const version = (req.query.version || 1) as number;

backend/src/services/learning-paths/database-learning-path-provider.ts

@@ -152,7 +152,7 @@ function convertTransition(
         throw new Error(`Learning object ${transition.next.learningObjectHruid}/${transition.next.language}/${transition.next.version} not found!`);
     } else {
         return {
-            _id: '' + index, // Retained for backwards compatibility. The index uniquely identifies the transition within the learning path.
+            _id: String(index), // Retained for backwards compatibility. The index uniquely identifies the transition within the learning path.
             default: false, // We don't work with default transitions but retain this for backwards compatibility.
             next: {
                 _id: nextNode._id + index, // Construct a unique ID for the transition for backwards compatibility.