From 0abe9b1bce1b3ea1e6eed41dd6d7c73e1ed91e12 Mon Sep 17 00:00:00 2001
From: Joyelle Ndagijimana <njoyelle2@gmail.com>
Date: Sat, 17 May 2025 19:07:52 +0200
Subject: [PATCH] fix: bug in assignment vertalingen

---
 .../assignments/DeadlineSelector.vue          | 19 ++++-
 frontend/src/utils/assignment-rules.ts        | 35 --------
 .../views/assignments/CreateAssignment.vue    | 20 ++++-
 frontend/tests/utils/assingment-rules.test.ts | 82 -------------------
 4 files changed, 37 insertions(+), 119 deletions(-)
 delete mode 100644 frontend/tests/utils/assingment-rules.test.ts

diff --git a/frontend/src/components/assignments/DeadlineSelector.vue b/frontend/src/components/assignments/DeadlineSelector.vue
index 13ac96ca..845a1a5a 100644
--- a/frontend/src/components/assignments/DeadlineSelector.vue
+++ b/frontend/src/components/assignments/DeadlineSelector.vue
@@ -1,6 +1,5 @@
 <script setup lang="ts">
     import { ref, watch } from "vue";
-    import { deadlineRules } from "@/utils/assignment-rules.ts";
 
     const emit = defineEmits<(e: "update:deadline", value: Date | null) => void>();
     const props = defineProps<{ deadline: Date | null }>();
@@ -19,6 +18,24 @@
             emit("update:deadline", null);
         }
     });
+
+    const deadlineRules = [
+        (value: string): string | boolean => {
+
+            const selectedDateTime = new Date(value);
+            const now = new Date();
+
+            if (isNaN(selectedDateTime.getTime())) {
+                return t("deadline-invalid");
+            }
+
+            if (selectedDateTime <= now) {
+                return t("deadline-past");
+            }
+
+            return true;
+        },
+    ];
 </script>
 
 <template>
diff --git a/frontend/src/utils/assignment-rules.ts b/frontend/src/utils/assignment-rules.ts
index 4fdde0d7..143a3f9c 100644
--- a/frontend/src/utils/assignment-rules.ts
+++ b/frontend/src/utils/assignment-rules.ts
@@ -1,20 +1,9 @@
-import {useI18n} from "vue-i18n";
-
-const { t } = useI18n();
 
 /**
  * Validation rule for the assignment title.
  *
  * Ensures that the title is not empty.
  */
-export const assignmentTitleRules = [
-    (value: string): string | boolean => {
-        if (value?.length >= 1) {
-            return true;
-        } // Title must not be empty
-        return t("title-required");
-    },
-];
 
 
 /**
@@ -22,34 +11,10 @@ export const assignmentTitleRules = [
  *
  * Ensures that at least one class is selected.
  */
-export const classRules = [
-    (value: string): string | boolean => {
-        if (value) {
-            return true;
-        }
-        return t("class-required");
-    },
-];
 
 /**
  * Validation rule for the deadline field.
  *
  * Ensures that a valid deadline is selected and is in the future.
  */
-export const deadlineRules = [
-    (value: string): string | boolean => {
 
-        const selectedDateTime = new Date(value);
-        const now = new Date();
-
-        if (isNaN(selectedDateTime.getTime())) {
-            return t("deadline-invalid");
-        }
-
-        if (selectedDateTime <= now) {
-            return t("deadline-past");
-        }
-
-        return true;
-    },
-];
diff --git a/frontend/src/views/assignments/CreateAssignment.vue b/frontend/src/views/assignments/CreateAssignment.vue
index ef07c443..839dc54c 100644
--- a/frontend/src/views/assignments/CreateAssignment.vue
+++ b/frontend/src/views/assignments/CreateAssignment.vue
@@ -1,7 +1,6 @@
 <script setup lang="ts">
 import { useI18n } from "vue-i18n";
 import { computed, onMounted, ref, watch } from "vue";
-import { assignmentTitleRules, classRules } from "@/utils/assignment-rules.ts";
 import auth from "@/services/auth/auth-service.ts";
 import { useTeacherClassesQuery } from "@/queries/teachers.ts";
 import { useRouter, useRoute } from "vue-router";
@@ -96,6 +95,25 @@ const learningPathRules = [
     }
 ];
 
+const assignmentTitleRules = [
+    (value: string): string | boolean => {
+        if (value?.length >= 1) {
+            return true;
+        } // Title must not be empty
+        return t("title-required");
+    },
+];
+
+const classRules = [
+    (value: string): string | boolean => {
+        if (value) {
+            return true;
+        }
+        return t("class-required");
+    },
+];
+
+
 </script>
 
 <template>
diff --git a/frontend/tests/utils/assingment-rules.test.ts b/frontend/tests/utils/assingment-rules.test.ts
deleted file mode 100644
index 3b6e5bfd..00000000
--- a/frontend/tests/utils/assingment-rules.test.ts
+++ /dev/null
@@ -1,82 +0,0 @@
-import { describe, expect, it } from "vitest";
-import {
-    assignmentTitleRules,
-    classRules,
-    deadlineRules,
-    descriptionRules,
-    learningPathRules,
-} from "../../src/utils/assignment-rules";
-
-describe("Validation Rules", () => {
-    describe("assignmentTitleRules", () => {
-        it("should return true for a valid title", () => {
-            const result = assignmentTitleRules[0]("Valid Title");
-            expect(result).toBe(true);
-        });
-
-        it("should return an error message for an empty title", () => {
-            const result = assignmentTitleRules[0]("");
-            expect(result).toBe("Title cannot be empty.");
-        });
-    });
-
-    describe("learningPathRules", () => {
-        it("should return true for a valid learning path", () => {
-            const result = learningPathRules[0]({ hruid: "123", title: "Path Title" });
-            expect(result).toBe(true);
-        });
-
-        it("should return an error message for an invalid learning path", () => {
-            const result = learningPathRules[0]({ hruid: "", title: "" });
-            expect(result).toBe("You must select a learning path.");
-        });
-    });
-
-    describe("classRules", () => {
-        it("should return true for a valid class", () => {
-            const result = classRules[0]("Class 1");
-            expect(result).toBe(true);
-        });
-
-        it("should return an error message for an empty class", () => {
-            const result = classRules[0]("");
-            expect(result).toBe("You must select at least one class.");
-        });
-    });
-
-    describe("deadlineRules", () => {
-        it("should return true for a valid future deadline", () => {
-            const futureDate = new Date(Date.now() + 1000 * 60 * 60).toISOString();
-            const result = deadlineRules[0](futureDate);
-            expect(result).toBe(true);
-        });
-
-        it("should return an error message for a past deadline", () => {
-            const pastDate = new Date(Date.now() - 1000 * 60 * 60).toISOString();
-            const result = deadlineRules[0](pastDate);
-            expect(result).toBe("The deadline must be in the future.");
-        });
-
-        it("should return an error message for an invalid date", () => {
-            const result = deadlineRules[0]("invalid-date");
-            expect(result).toBe("Invalid date or time.");
-        });
-
-        it("should return an error message for an empty deadline", () => {
-            const result = deadlineRules[0]("");
-            expect(result).toBe("You must set a deadline.");
-        });
-    });
-
-    describe("descriptionRules", () => {
-        it("should return true for a valid description", () => {
-            const result = descriptionRules[0]("This is a valid description.");
-            expect(result).toBe(true);
-        });
-
-        it("should return an error message for an empty description", () => {
-            const result = descriptionRules[0]("");
-            expect(result).toBe("Description cannot be empty.");
-        });
-    });
-});