tdpeuter/2025SELab2-project-Dwengo
tdpeuter/2025SELab2-project-Dwengo
Archived
1
Fork 0
Code Issues Releases 4 Packages 2 Wiki Activity

refactor: gebruikt class controller

Browse source
This commit is contained in:
laurejablonski 2025-04-11 12:24:18 +02:00
parent 0694324c83
commit 06d2489a04
1 changed files with 9 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

39
frontend/src/views/classes/StudentClasses.vue
View file

@ -6,15 +6,14 @@
import type { ClassDTO } from "@dwengo-1/common/interfaces/class"; import type { ClassDTO } from "@dwengo-1/common/interfaces/class";
import { useCreateJoinRequestMutation, useStudentClassesQuery } from "@/queries/students"; import { useCreateJoinRequestMutation, useStudentClassesQuery } from "@/queries/students";
import type { StudentDTO } from "@dwengo-1/common/interfaces/student"; import type { StudentDTO } from "@dwengo-1/common/interfaces/student";
import { StudentController } from "@/controllers/students"; import { StudentController, type StudentResponse } from "@/controllers/students";
import type { TeacherDTO } from "@dwengo-1/common/interfaces/teacher"; import type { TeacherDTO } from "@dwengo-1/common/interfaces/teacher";
import { TeacherController } from "@/controllers/teachers"; import { TeacherController } from "@/controllers/teachers";
import type { ClassesResponse } from "@/controllers/classes"; import { ClassController, type ClassesResponse } from "@/controllers/classes";
import UsingQueryResult from "@/components/UsingQueryResult.vue"; import UsingQueryResult from "@/components/UsingQueryResult.vue";
const { t } = useI18n(); const { t } = useI18n();
const studentController: StudentController = new StudentController(); const classController: ClassController = new ClassController();
const teacherController: TeacherController = new TeacherController();
// Username of logged in student // Username of logged in student
const username = ref<string | undefined>(undefined); const username = ref<string | undefined>(undefined);
@ -48,20 +47,10 @@
students.value = []; students.value = [];
dialog.value = true; dialog.value = true;
// Fetch students from their usernames to display their full names
const studentDTOs: (StudentDTO | null)[] = await Promise.all(
c.students.map(async (uid) => {
try {
const res = await studentController.getByUsername(uid);
return res.student;
} catch (_) {
return null;
}
}),
);
// Only show students that are not fetched ass *null* // TODO: change to use class query
students.value = studentDTOs.filter(Boolean) as StudentDTO[]; const studentDTOs: StudentDTO[] = (await classController.getStudents(c.id)).students as StudentDTO[];
students.value = studentDTOs;
} }
async function openTeacherDialog(c: ClassDTO): Promise<void> { async function openTeacherDialog(c: ClassDTO): Promise<void> {
@ -72,19 +61,9 @@
teachers.value = []; teachers.value = [];
dialog.value = true; dialog.value = true;
// Fetch names of teachers // TODO: change to use class query
const teacherDTOs: (TeacherDTO | null)[] = await Promise.all( const teacherDTOs: TeacherDTO[] = (await classController.getTeachers(c.id)).teachers as TeacherDTO[];
c.teachers.map(async (uid) => { teachers.value = teacherDTOs;
try {
const res = await teacherController.getByUsername(uid);
return res.teacher;
} catch (_) {
return null;
}
}),
);
teachers.value = teacherDTOs.filter(Boolean) as TeacherDTO[];
} }
// Hold the code a student gives in to join a class // Hold the code a student gives in to join a class