From 076381915dc1082c24a7212dcb0b4e0062a75bcc Mon Sep 17 00:00:00 2001
From: lbarraga <lukas.barragantorres@ugent.be>
Date: Mon, 17 Apr 2023 16:00:58 +0200
Subject: [PATCH] fix issues

---
 app/src/main/java/be/ugent/sel/studeez/StudeezApp.kt     | 4 ++--
 .../studeez/common/composable/PrimaryScreenComposable.kt | 2 +-
 .../ugent/sel/studeez/screens/drawer/DrawerViewModel.kt  | 9 ++-------
 .../be/ugent/sel/studeez/screens/home/HomeViewModel.kt   | 4 ++--
 .../ugent/sel/studeez/screens/session/SessionScreen.kt   | 2 ++
 .../screens/timer_overview/TimerOverviewScreen.kt        | 2 ++
 6 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/app/src/main/java/be/ugent/sel/studeez/StudeezApp.kt b/app/src/main/java/be/ugent/sel/studeez/StudeezApp.kt
index ff46729..c1a3ea2 100644
--- a/app/src/main/java/be/ugent/sel/studeez/StudeezApp.kt
+++ b/app/src/main/java/be/ugent/sel/studeez/StudeezApp.kt
@@ -116,11 +116,11 @@ fun NavGraphBuilder.studeezGraph(appState: StudeezAppstate) {
     }
 
     composable(StudeezDestinations.TIMER_OVERVIEW_SCREEN) {
-        TimerOverviewScreen(openAndPopUp)
+        TimerOverviewScreen(open, openAndPopUp)
     }
 
     composable(StudeezDestinations.SESSION_SCREEN) {
-        SessionScreen(openAndPopUp)
+        SessionScreen(open, openAndPopUp)
     }
     
     // TODO Timers screen
diff --git a/app/src/main/java/be/ugent/sel/studeez/common/composable/PrimaryScreenComposable.kt b/app/src/main/java/be/ugent/sel/studeez/common/composable/PrimaryScreenComposable.kt
index 009281f..df9b346 100644
--- a/app/src/main/java/be/ugent/sel/studeez/common/composable/PrimaryScreenComposable.kt
+++ b/app/src/main/java/be/ugent/sel/studeez/common/composable/PrimaryScreenComposable.kt
@@ -22,7 +22,7 @@ fun PrimaryScreenTemplate(
     title: String,
     open: (String) -> Unit,
     openAndPopUp: (String, String) -> Unit,
-    action: @Composable RowScope.() -> Unit,
+    action: @Composable RowScope.() -> Unit = {},
     content: @Composable (PaddingValues) -> Unit
 ) {
     val scaffoldState: ScaffoldState = rememberScaffoldState()
diff --git a/app/src/main/java/be/ugent/sel/studeez/screens/drawer/DrawerViewModel.kt b/app/src/main/java/be/ugent/sel/studeez/screens/drawer/DrawerViewModel.kt
index d3460cf..7e03b9b 100644
--- a/app/src/main/java/be/ugent/sel/studeez/screens/drawer/DrawerViewModel.kt
+++ b/app/src/main/java/be/ugent/sel/studeez/screens/drawer/DrawerViewModel.kt
@@ -19,13 +19,8 @@ class DrawerViewModel @Inject constructor(
         open(HOME_SCREEN)
     }
 
-    fun onTimersClick(open: (String) -> Unit) {
-        // TODO
-    }
-
-    fun onTimersClick(openAndPopup: (String, String) -> Unit) {
-        // TODO is niet altijd het homescreen
-        openAndPopup(StudeezDestinations.TIMER_OVERVIEW_SCREEN, StudeezDestinations.HOME_SCREEN)
+    fun onTimersClick(openAndPopup: (String) -> Unit) {
+        openAndPopup(StudeezDestinations.TIMER_OVERVIEW_SCREEN)
     }
 
     fun onSettingsClick(open: (String) -> Unit) {
diff --git a/app/src/main/java/be/ugent/sel/studeez/screens/home/HomeViewModel.kt b/app/src/main/java/be/ugent/sel/studeez/screens/home/HomeViewModel.kt
index b035223..f0f7b64 100644
--- a/app/src/main/java/be/ugent/sel/studeez/screens/home/HomeViewModel.kt
+++ b/app/src/main/java/be/ugent/sel/studeez/screens/home/HomeViewModel.kt
@@ -15,8 +15,8 @@ class HomeViewModel @Inject constructor(
     logService: LogService
 ) : StudeezViewModel(logService) {
 
-    fun onStartSessionClick(openAndPopUp: (String, String) -> Unit) {
-        openAndPopUp(StudeezDestinations.SESSION_SCREEN, StudeezDestinations.HOME_SCREEN)
+    fun onStartSessionClick(openAndPopUp: (String) -> Unit) {
+        openAndPopUp(StudeezDestinations.SESSION_SCREEN)
     }
 
     fun onLogoutClick(openAndPopup: (String, String) -> Unit) {
diff --git a/app/src/main/java/be/ugent/sel/studeez/screens/session/SessionScreen.kt b/app/src/main/java/be/ugent/sel/studeez/screens/session/SessionScreen.kt
index e87bac5..d69470e 100644
--- a/app/src/main/java/be/ugent/sel/studeez/screens/session/SessionScreen.kt
+++ b/app/src/main/java/be/ugent/sel/studeez/screens/session/SessionScreen.kt
@@ -18,11 +18,13 @@ import kotlinx.coroutines.delay
 
 @Composable
 fun SessionScreen(
+    open: (String) -> Unit,
     openAndPopUp: (String, String) -> Unit,
     viewModel: SessionViewModel = hiltViewModel()
 ) {
     PrimaryScreenTemplate(
         title = resources().getString(R.string.start_session),
+        open = open,
         openAndPopUp = openAndPopUp
     ) {
         Timer(viewModel)
diff --git a/app/src/main/java/be/ugent/sel/studeez/screens/timer_overview/TimerOverviewScreen.kt b/app/src/main/java/be/ugent/sel/studeez/screens/timer_overview/TimerOverviewScreen.kt
index dcf7516..fccbc66 100644
--- a/app/src/main/java/be/ugent/sel/studeez/screens/timer_overview/TimerOverviewScreen.kt
+++ b/app/src/main/java/be/ugent/sel/studeez/screens/timer_overview/TimerOverviewScreen.kt
@@ -27,6 +27,7 @@ import be.ugent.sel.studeez.resources
 
 @Composable
 fun TimerOverviewScreen(
+    open: (String) -> Unit,
     openAndPopUp: (String, String) -> Unit,
     viewModel: TimerOverviewViewModel = hiltViewModel()
 ) {
@@ -35,6 +36,7 @@ fun TimerOverviewScreen(
 
     PrimaryScreenTemplate(
         title = resources().getString(R.string.timers),
+        open = open,
         openAndPopUp = openAndPopUp
     ) {