refactor: abstract app user creation via custom options

modules/apps/arr/default.nix

@@ -95,22 +95,17 @@ in {
     };
 
     # Create a user for each app.
-    users.users = let
+    homelab.appUsers = let
       mkUser = uid: {
-        uid = lib.mkForce uid;
+        inherit uid;
-        isSystemUser = true;
         group = config.users.groups.media.name;
-        home = "/var/empty";
-        shell = null;
       };
     in {
       bazarr = lib.mkIf cfg.bazarr.enable (mkUser 3003);
       prowlarr = lib.mkIf cfg.prowlarr.enable (mkUser 3004);
-      qbittorrent = lib.mkIf cfg.qbittorrent.enable (mkUser 3005) // {
+      qbittorrent = lib.mkIf cfg.qbittorrent.enable ((mkUser 3005) // {
-        extraGroups = [
+        extraGroups = [ config.users.groups.apps.name ];
-          config.users.groups.apps.name
+      });
-        ];
-      };
       radarr = lib.mkIf cfg.radarr.enable (mkUser 3006);
       sonarr = lib.mkIf cfg.sonarr.enable (mkUser 3007);
     };

modules/apps/calibre/default.nix

@@ -34,12 +34,9 @@ in {
         virtualisation.containers.enable = true;
       };
 
-      users.users.calibre = {
+      homelab.appUsers.calibre = {
-        uid = lib.mkForce 3010;
+        uid = 3010;
-        isSystemUser = true;
         group = config.users.groups.media.name;
-        home = "/var/empty";
-        shell = null;
       };
 
       homelab.nfsMounts."${books}" = {

modules/apps/gitea/default.nix

@@ -30,12 +30,8 @@ in {
       virtualisation.containers.enable = true;
     };
 
-    users.users.gitea = {
+    homelab.appUsers.gitea = {
-      uid = lib.mkForce UID;
+      uid = UID;
-      isSystemUser = true;
-      group = config.users.groups.apps.name;
-      home = "/var/empty";
-      shell = null;
     };
 
     # Use filesystem mounts because rootless containers otherwise don't have access to the mount path (nested in docker directories).

modules/apps/homepage/default.nix

@@ -26,12 +26,8 @@ in {
       virtualisation.containers.enable = true;
     };
 
-    users.users.homepage = {
+    homelab.appUsers.homepage = {
-      uid = lib.mkForce 3018;
+      uid = 3018;
-      isSystemUser = true;
-      group = config.users.groups.apps.name;
-      home = "/var/empty";
-      shell = null;
     };
 
     homelab.nfsMounts."${homepage-config}" = {

modules/apps/jellyfin/default.nix

@@ -36,15 +36,9 @@ in {
       "/srv/photo" = mkMount "192.168.0.11:/mnt/BIG/MEDIA/PHOTO/ARCHIVE";
     };
 
-    users.users.jellyfin = {
+    homelab.appUsers.jellyfin = {
-      uid = lib.mkForce UID;
+      uid = UID;
-      isSystemUser = true;
+      extraGroups = [ config.users.groups.media.name ];
-      group = config.users.groups.apps.name;
-      extraGroups = [
-        config.users.groups.media.name
-      ];
-      home = "/var/empty";
-      shell = null;
     };
 
     # Make sure the Docker network exists.

modules/common/default.nix

@@ -3,6 +3,7 @@
     ./docker.nix
     ./monitoring.nix
     ./nfs.nix
+    ./users.nix
   ];
 
   config = {

modules/common/users.nix

@@ -0,0 +1,37 @@
+{ config, lib, ... }:
+
+{
+  options.homelab.appUsers = lib.mkOption {
+    type = lib.types.attrsOf (lib.types.submodule {
+      options = {
+        uid = lib.mkOption {
+          type = lib.types.int;
+          description = "The user ID for the app user";
+        };
+        group = lib.mkOption {
+          type = lib.types.str;
+          default = config.users.groups.apps.name;
+          description = "The primary group for the app user";
+        };
+        extraGroups = lib.mkOption {
+          type = lib.types.listOf lib.types.str;
+          default = [];
+          description = "Extra groups for the app user";
+        };
+      };
+    });
+    default = {};
+    description = "App users to automatically create with standard homelab options";
+  };
+
+  config = {
+    users.users = lib.mapAttrs (name: cfg: {
+      uid = lib.mkForce cfg.uid;
+      isSystemUser = true;
+      group = cfg.group;
+      extraGroups = cfg.extraGroups;
+      home = "/var/empty";
+      shell = null;
+    }) config.homelab.appUsers;
+  };
+}